Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(993)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageToolbar.java

Issue 1894703002: [Offline pages] Removing offline pages from Bookmarks UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing feedback from Ian, fixing compilation issue Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageToolbar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageToolbar.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageToolbar.java
index 43a48a55979d826c442931986aa8d9a01bba5ad1..5a09293724e91cfcd2657451b0eeb32a11855de8 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageToolbar.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageToolbar.java
@@ -13,7 +13,6 @@ import android.widget.TextView;
import org.chromium.base.ApiCompatibilityUtils;
import org.chromium.chrome.R;
-import org.chromium.chrome.browser.offlinepages.OfflinePageUtils;
import org.chromium.chrome.browser.widget.TintedDrawable;
/**
@@ -48,11 +47,10 @@ public class NewTabPageToolbar extends LinearLayout {
super.onFinishInflate();
mBookmarksButton = initButton(R.id.bookmarks_button, R.drawable.btn_star);
mRecentTabsButton = initButton(R.id.recent_tabs_button, R.drawable.btn_recents);
+ ((TextView) mBookmarksButton.getChildAt(0)).setText(R.string.ntp_bookmarks);
((TextView) mBookmarksButton.getChildAt(0))
Ian Wen 2016/04/19 00:11:09 Nit: Let's keep it 2 lines instead of 3? We might
fgorski 2016/04/19 04:35:11 Done. git cl format complains again here. I don't
- .setText(OfflinePageUtils.getStringId(R.string.ntp_bookmarks));
- ((TextView) mBookmarksButton.getChildAt(0))
- .setContentDescription(getResources().getString(OfflinePageUtils.getStringId(
- R.string.accessibility_ntp_toolbar_btn_bookmarks)));
+ .setContentDescription(
+ getResources().getString(R.string.accessibility_ntp_toolbar_btn_bookmarks));
mInterestsButton = initButton(R.id.interests_button, R.drawable.btn_star_filled);
}

Powered by Google App Engine
This is Rietveld 408576698