Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1056)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 1894703002: [Offline pages] Removing offline pages from Bookmarks UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing feedback from Ian, fixing compilation issue Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
index cfa226b606fc239b06e8a3bd352e1e658b363452..09a9727250581c8d1bd7779cc2ec94f6a256641f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
@@ -120,6 +120,7 @@ import org.chromium.chrome.browser.util.ColorUtils;
import org.chromium.chrome.browser.util.FeatureUtilities;
import org.chromium.chrome.browser.webapps.AddToHomescreenDialog;
import org.chromium.chrome.browser.widget.ControlContainer;
+import org.chromium.components.bookmarks.BookmarkId;
import org.chromium.content.browser.ContentVideoView;
import org.chromium.content.browser.ContentViewCore;
import org.chromium.content.common.ContentSwitches;
@@ -1058,8 +1059,13 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
if (!tabToBookmark.isClosing() && tabToBookmark.isInitialized()) {
// The BookmarkModel will be destroyed by BookmarkUtils#addOrEditBookmark() when
// done.
- BookmarkUtils.addOrEditBookmark(bookmarkId, bookmarkModel,
- tabToBookmark, getSnackbarManager(), ChromeActivity.this);
+ BookmarkId newBookmarkId =
Ian Wen 2016/04/19 00:11:09 Nit: It seems these 3 lines can be reformatted to
fgorski 2016/04/19 04:35:11 I think it is one character too long.
+ BookmarkUtils.addOrEditBookmark(bookmarkId, bookmarkModel,
+ tabToBookmark, getSnackbarManager(), ChromeActivity.this);
+ // If a new bookmark was created, try to save an offline page for it.
+ if (newBookmarkId != null && newBookmarkId.getId() != bookmarkId) {
+ OfflinePageUtils.saveBookmarkOffline(newBookmarkId, tabToBookmark);
+ }
} else {
bookmarkModel.destroy();
}

Powered by Google App Engine
This is Rietveld 408576698