Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java

Issue 1894703002: [Offline pages] Removing offline pages from Bookmarks UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Marking more methods as visible for testing Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
index d0e3bbbd5e27c6688c39d615ca4ed9a33bfee92a..1a4000fe2ef074b13799cc02da7326dab64de9f9 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
@@ -185,22 +185,12 @@ public class OfflinePageBridge {
}
/**
- * @return The mode of the offline pages feature. Uses
- * {@see org.chromium.components.offlinepages.FeatureMode} enum.
- */
- public static int getFeatureMode() {
- ThreadUtils.assertOnUiThread();
- if (sFeatureMode == null) sFeatureMode = nativeGetFeatureMode();
- return sFeatureMode;
- }
-
- /**
* @return True if the offline pages feature is enabled, regardless whether bookmark or saved
* page shown in UI strings.
*/
public static boolean isEnabled() {
ThreadUtils.assertOnUiThread();
- return getFeatureMode() != FeatureMode.DISABLED;
+ return nativeGetFeatureMode() != FeatureMode.DISABLED;
}
/**
@@ -240,7 +230,7 @@ public class OfflinePageBridge {
*
* @param callback The callback to run when the operation completes.
*/
-
+ @VisibleForTesting
public void getAllPages(final MultipleOfflinePageItemCallback callback) {
List<OfflinePageItem> result = new ArrayList<>();
nativeGetAllPages(mNativeOfflinePageBridge, result, callback);
@@ -287,6 +277,7 @@ public class OfflinePageBridge {
* @return A {@link OfflinePageItem} matching the bookmark Id or <code>null</code> if none
* exist.
*/
+ @VisibleForTesting
public void getPagesByClientId(
final ClientId clientId, final MultipleOfflinePageItemCallback callback) {
runWhenLoaded(new Runnable() {
@@ -433,6 +424,7 @@ public class OfflinePageBridge {
* @param callback Interface that contains a callback.
* @see DeletePageCallback
*/
+ @VisibleForTesting
public void deletePage(final ClientId clientId, DeletePageCallback callback) {
assert mIsNativeOfflinePageModelLoaded;
ArrayList<ClientId> ids = new ArrayList<ClientId>();

Powered by Google App Engine
This is Rietveld 408576698