chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRow.java - Issue 1894703002: [Offline pages] Removing offline pages from Bookmarks UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRow.java

Issue 1894703002: [Offline pages] Removing offline pages from Bookmarks UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Marking more methods as visible for testing Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRecyclerView.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkSearchView.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRow.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRow.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRow.java

index 4094f43385bf8fcd3eb4ee8924ee921c7acb9dd0..91589e4ad6c43612f5d3b179e8b3afbfd00b2aa3 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRow.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRow.java

@@ -157,8 +157,7 @@ abstract class BookmarkRow extends FrameLayout implements BookmarkUIObserver,

BookmarkAddEditFolderActivity.startEditFolderActivity(

getContext(), item.getId());

} else {

- BookmarkUtils.startEditActivity(

- getContext(), item.getId(), null);

+ BookmarkUtils.startEditActivity(getContext(), item.getId());

}

} else if (position == 2) {

BookmarkFolderSelectActivity.startFolderSelectActivity(getContext(),

@@ -281,10 +280,6 @@ abstract class BookmarkRow extends FrameLayout implements BookmarkUIObserver,

}

@Override

- public void onFilterStateSet(BookmarkFilter filter) {

- }

- @Override

public void onSelectionStateChange(List<BookmarkId> selectedBookmarks) {

updateSelectionState();

}