Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1545)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManager.java

Issue 1894703002: [Offline pages] Removing offline pages from Bookmarks UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Marking more methods as visible for testing Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManager.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManager.java
index d4ed5a7f4e6cba01bbd4cb55150862717ac7d033..b53aedd57fc5da084068a1e495d15432bacb99b6 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkManager.java
@@ -269,9 +269,7 @@ public class BookmarkManager implements BookmarkDelegate {
if (state.mState != BookmarkUIState.STATE_LOADING) {
// Loading state may be pushed to the stack but should never be stored in preferences.
- if (state.mShouldPersist) {
- BookmarkUtils.setLastUsedUrl(mActivity, state.mUrl);
- }
+ BookmarkUtils.setLastUsedUrl(mActivity, state.mUrl);
// If a loading state is replaced by another loading state, do not notify this change.
if (mUrlChangeListener != null) {
mUrlChangeListener.onBookmarkUIStateChange(state.mUrl);
@@ -305,11 +303,6 @@ public class BookmarkManager implements BookmarkDelegate {
}
@Override
- public void openFilter(BookmarkFilter filter) {
- setState(BookmarkUIState.createFilterState(filter, mBookmarkModel));
- }
-
- @Override
public void clearSelection() {
mSelectedBookmarks.clear();
for (BookmarkUIObserver observer : mUIObservers) {
@@ -360,9 +353,6 @@ public class BookmarkManager implements BookmarkDelegate {
// UIObservers, which means that there will be no observers at the time. Do nothing.
assert mUIObservers.isEmpty();
break;
- case BookmarkUIState.STATE_FILTER:
- observer.onFilterStateSet(mStateStack.peek().mFilter);
- break;
default:
assert false : "State not valid";
break;

Powered by Google App Engine
This is Rietveld 408576698