Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1566)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkDrawerListView.java

Issue 1894703002: [Offline pages] Removing offline pages from Bookmarks UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Marking more methods as visible for testing Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkDrawerListView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkDrawerListView.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkDrawerListView.java
index 933bb14ec511b74b872d676ba1e67ec986a00476..6abf89025af588db41215910b6846c903fa6f3c0 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkDrawerListView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkDrawerListView.java
@@ -11,10 +11,7 @@ import android.view.View;
import android.widget.AdapterView;
import android.widget.ListView;
-import org.chromium.base.metrics.RecordHistogram;
import org.chromium.chrome.browser.bookmarks.BookmarkBridge.BookmarkModelObserver;
-import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;
-import org.chromium.chrome.browser.offlinepages.OfflinePageUtils;
import org.chromium.components.bookmarks.BookmarkId;
import java.util.List;
@@ -49,20 +46,6 @@ class BookmarkDrawerListView extends ListView implements BookmarkUIObserver {
BookmarkDrawerListViewAdapter.Item item =
(BookmarkDrawerListViewAdapter.Item) mAdapter.getItem(position);
- if (OfflinePageBridge.isEnabled()) {
- int currentState = mDelegate.getCurrentState();
- boolean isConnected = OfflinePageUtils.isConnected();
- if (item.mType == BookmarkDrawerListViewAdapter.TYPE_FILTER
- && currentState != BookmarkUIState.STATE_FILTER) {
- RecordHistogram.recordBooleanHistogram(
- "OfflinePages.Filter.OnlineWhenEntering", isConnected);
- } else if (item.mType != BookmarkDrawerListViewAdapter.TYPE_FILTER
- && currentState == BookmarkUIState.STATE_FILTER) {
- RecordHistogram.recordBooleanHistogram(
- "OfflinePages.Filter.OnlineWhenLeaving", isConnected);
- }
- }
-
switch (item.mType) {
case BookmarkDrawerListViewAdapter.TYPE_FOLDER:
mDelegate.openFolder(item.mFolderId);
@@ -70,9 +53,6 @@ class BookmarkDrawerListView extends ListView implements BookmarkUIObserver {
case BookmarkDrawerListViewAdapter.TYPE_ALL_ITEMS:
mDelegate.openAllBookmarks();
break;
- case BookmarkDrawerListViewAdapter.TYPE_FILTER:
- mDelegate.openFilter(item.mFilter);
- break;
default:
assert false;
}
@@ -117,13 +97,6 @@ class BookmarkDrawerListView extends ListView implements BookmarkUIObserver {
}
@Override
- public void onFilterStateSet(BookmarkFilter filter) {
- mAdapter.updateList();
- setItemChecked(mAdapter.getItemPosition(BookmarkUIState.STATE_FILTER, filter),
- true);
- }
-
- @Override
public void onSelectionStateChange(List<BookmarkId> selectedBookmarks) {
}
}

Powered by Google App Engine
This is Rietveld 408576698