Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkContentView.java

Issue 1894703002: [Offline pages] Removing offline pages from Bookmarks UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Marking more methods as visible for testing Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkContentView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkContentView.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkContentView.java
index d27f44eee22c9d57dda7a033d57fc43d820b1520..612aed2a8ff0d28a057946cd50721b003592a012 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkContentView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkContentView.java
@@ -12,7 +12,6 @@ import android.widget.TextView;
import org.chromium.base.ApiCompatibilityUtils;
import org.chromium.chrome.R;
-import org.chromium.chrome.browser.offlinepages.OfflinePageUtils;
import org.chromium.chrome.browser.widget.FadingShadow;
import org.chromium.chrome.browser.widget.FadingShadowView;
import org.chromium.chrome.browser.widget.LoadingView;
@@ -45,7 +44,7 @@ public class BookmarkContentView extends RelativeLayout implements
super.onFinishInflate();
mItemsContainer = (BookmarkRecyclerView) findViewById(R.id.bookmark_items_container);
TextView emptyView = (TextView) findViewById(R.id.bookmark_empty_view);
- emptyView.setText(OfflinePageUtils.getStringId(R.string.bookmarks_folder_empty));
+ emptyView.setText(R.string.bookmarks_folder_empty);
mItemsContainer.setEmptyView(emptyView);
mActionBar = (BookmarkActionBar) findViewById(R.id.bookmark_action_bar);
mLoadingView = (LoadingView) findViewById(R.id.bookmark_initial_loading_view);
@@ -102,11 +101,6 @@ public class BookmarkContentView extends RelativeLayout implements
}
@Override
- public void onFilterStateSet(BookmarkFilter filter) {
- mLoadingView.hideLoadingUI();
- }
-
- @Override
public void onSelectionStateChange(List<BookmarkId> selectedBookmarks) {
}
}

Powered by Google App Engine
This is Rietveld 408576698