chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActivity.java - Issue 1894703002: [Offline pages] Removing offline pages from Bookmarks UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActivity.java

Issue 1894703002: [Offline pages] Removing offline pages from Bookmarks UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Marking more methods as visible for testing Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActionBar.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkAddActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActivity.java

index 484c0cf64317c02ba33efae3b8872177bdb549d8..b3ba4259aec95a307f9dde7b087161953a0014cf 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActivity.java

@@ -12,7 +12,6 @@ import android.view.WindowManager;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.UrlConstants;

-import org.chromium.chrome.browser.offlinepages.OfflinePageUtils;

import org.chromium.chrome.browser.snackbar.SnackbarManager;

import org.chromium.chrome.browser.snackbar.SnackbarManager.SnackbarManageable;

import org.chromium.components.bookmarks.BookmarkId;

@@ -40,8 +39,7 @@ public class BookmarkActivity extends BookmarkActivityBase implements SnackbarMa

mBookmarkManager.updateForUrl(url);

setContentView(mBookmarkManager.getView());

- BookmarkUtils.setTaskDescriptionInDocumentMode(

- this, getString(OfflinePageUtils.getStringId(R.string.bookmarks)));

+ BookmarkUtils.setTaskDescriptionInDocumentMode(this, getString(R.string.bookmarks));

// Hack to work around inferred theme false lint error: http://crbug.com/445633

assert (R.layout.bookmark_main_content != 0);