chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java - Issue 1894703002: [Offline pages] Removing offline pages from Bookmarks UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

Issue 1894703002: [Offline pages] Removing offline pages from Bookmarks UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Marking more methods as visible for testing Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActionBar.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

index 4989b9cde3aa09ad1efba2a6d76eee39cda8bef0..dc57cc30d74317491e09e2647296458f50d56fbd 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java

@@ -15,7 +15,6 @@ import org.chromium.chrome.browser.ShortcutHelper;

import org.chromium.chrome.browser.UrlConstants;

import org.chromium.chrome.browser.bookmarks.BookmarkBridge;

import org.chromium.chrome.browser.multiwindow.MultiWindowUtils;

-import org.chromium.chrome.browser.offlinepages.OfflinePageUtils;

import org.chromium.chrome.browser.omaha.UpdateMenuItemHelper;

import org.chromium.chrome.browser.preferences.ManagedPreferencesUtils;

import org.chromium.chrome.browser.preferences.PrefServiceBridge;

@@ -122,8 +121,7 @@ public class AppMenuPropertiesDelegate {

recentTabsMenuItem.setTitle(R.string.menu_recent_tabs);

MenuItem allBookmarksMenuItem = menu.findItem(R.id.all_bookmarks_menu_id);

- allBookmarksMenuItem.setTitle(

- mActivity.getString(OfflinePageUtils.getStringId(R.string.menu_bookmarks)));

+ allBookmarksMenuItem.setTitle(mActivity.getString(R.string.menu_bookmarks));

// Don't allow "chrome://" pages to be shared.

menu.findItem(R.id.share_row_menu_id).setVisible(!isChromeScheme);