chrome/android/java/res/layout/bookmark_row_content.xml - Issue 1894703002: [Offline pages] Removing offline pages from Bookmarks UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/bookmark_row_content.xml

Issue 1894703002: [Offline pages] Removing offline pages from Bookmarks UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Marking more methods as visible for testing Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/layout/bookmark_offline_pages_storage_space_header.xml ('k') | chrome/android/java/res/values/dimens.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/layout/bookmark_row_content.xml

diff --git a/chrome/android/java/res/layout/bookmark_row_content.xml b/chrome/android/java/res/layout/bookmark_row_content.xml

index b51ec19340aa2e233180faedc6f0837a3d96679b..8f195f52acd72efe88f89039697309d5558b3159 100644

--- a/chrome/android/java/res/layout/bookmark_row_content.xml

+++ b/chrome/android/java/res/layout/bookmark_row_content.xml

@@ -22,34 +22,17 @@

android:contentDescription="@null"

android:scaleType="center" />

- <LinearLayout

+ <TextView

+ android:id="@+id/title"

android:layout_width="0dp"

android:layout_height="wrap_content"

android:layout_weight="1"

android:minHeight="48dp"

+ android:singleLine="true"

android:gravity="center_vertical"

- android:orientation="vertical" >

- <TextView

- android:id="@+id/title"

- android:layout_width="match_parent"

- android:layout_height="wrap_content"

- android:singleLine="true"

- android:textAlignment="viewStart"

- android:textColor="@color/default_text_color"

- android:textSize="16sp" />

- <TextView

- android:id="@+id/offline_page_size"

- android:layout_width="match_parent"

- android:layout_height="wrap_content"

- android:singleLine="true"

- android:textAlignment="viewStart"

- android:textColor="@color/secondary_text_default_material_light"

- android:textSize="15sp"

- android:visibility="gone" />

- </LinearLayout>

+ android:textAlignment="viewStart"

+ android:textColor="@color/default_text_color"

+ android:textSize="16sp" />

<org.chromium.chrome.browser.widget.TintedImageButton

android:id="@+id/more"