Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 1892843002: Revert of (Tiny) Temporarily enable hang report capture. (Closed)

Created:
4 years, 8 months ago by manzagop (departed)
Modified:
4 years, 8 months ago
CC:
chromium-reviews, Sigurður Ásgeirsson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of (Tiny) Temporarily enable hang report capture. (patchset #4 id:80001 of https://chromiumcodereview.appspot.com/1891563002/ ) Reason for revert: Single day experiment is complete. Original issue's description: > Temporarily enable hang report capture. > > Overview: > Browser process hangs are believed to be responsible for a large > fraction of browser unclean shutdowns on Windows. This patch enables > hang report capture to get visibility into the problem. > > Note: > - Capture only occurs on canary Chrome for users with stats consent. > - The plan is to release for a single day. > > BUG=478209 > > Committed: https://crrev.com/738c706910c84318db6f5309a1ff4c3584338722 > Cr-Commit-Position: refs/heads/master@{#387473} TBR=jochen@chromium.org,pmonette@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=478209 Committed: https://crrev.com/fc8ea0d7070b47fa7d4e8849cbd7f9b3e6466159 Cr-Commit-Position: refs/heads/master@{#387589}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M build/common.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/kasko/kasko.gni View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
manzagop (departed)
Created Revert of (Tiny) Temporarily enable hang report capture.
4 years, 8 months ago (2016-04-15 13:00:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892843002/1
4 years, 8 months ago (2016-04-15 13:00:21 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 8 months ago (2016-04-15 13:00:23 UTC) #4
Sigurður Ásgeirsson
lgtm
4 years, 8 months ago (2016-04-15 13:08:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1892843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1892843002/1
4 years, 8 months ago (2016-04-15 13:52:30 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 13:53:07 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 13:54:19 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc8ea0d7070b47fa7d4e8849cbd7f9b3e6466159
Cr-Commit-Position: refs/heads/master@{#387589}

Powered by Google App Engine
This is Rietveld 408576698