Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 18927003: [Autofill] Don't validate China UnionPay cards with the Luhn checksum. (Closed)

Created:
7 years, 5 months ago by Ilya Sherman
Modified:
7 years, 5 months ago
Reviewers:
Albert Bodenhamer
CC:
chromium-reviews, Raman Kakilate, benquan, ahutter, browser-components-watch_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

[Autofill] Don't validate China UnionPay cards with the Luhn checksum. BUG=242274 TEST=unit_tests R=abodenha@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211986

Patch Set 1 #

Total comments: 2

Patch Set 2 : Support cards of length up to 19 #

Patch Set 3 : Rebase #

Patch Set 4 : Parens for order of operations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -2 lines) Patch
M components/autofill/core/browser/credit_card.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/browser/credit_card.cc View 1 6 chunks +14 lines, -1 line 0 comments Download
M components/autofill/core/browser/credit_card_unittest.cc View 4 chunks +7 lines, -1 line 0 comments Download
M components/autofill/core/browser/validation.cc View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M components/autofill/core/browser/validation_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M components/autofill_strings.grdp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Ilya Sherman
7 years, 5 months ago (2013-07-11 05:58:42 UTC) #1
Albert Bodenhamer
https://codereview.chromium.org/18927003/diff/1/components/autofill/core/browser/credit_card.cc File components/autofill/core/browser/credit_card.cc (right): https://codereview.chromium.org/18927003/diff/1/components/autofill/core/browser/credit_card.cc#newcode207 components/autofill/core/browser/credit_card.cc:207: // UnionPay 62 16 Wikipedia claims 62 or 88 ...
7 years, 5 months ago (2013-07-11 16:28:42 UTC) #2
Ilya Sherman
https://codereview.chromium.org/18927003/diff/1/components/autofill/core/browser/credit_card.cc File components/autofill/core/browser/credit_card.cc (right): https://codereview.chromium.org/18927003/diff/1/components/autofill/core/browser/credit_card.cc#newcode207 components/autofill/core/browser/credit_card.cc:207: // UnionPay 62 16 On 2013/07/11 16:28:42, Albert Bodenhamer ...
7 years, 5 months ago (2013-07-12 01:06:47 UTC) #3
Ilya Sherman
Albert, PTAL :)
7 years, 5 months ago (2013-07-16 00:36:11 UTC) #4
Albert Bodenhamer
LGTM Sorry for the delay.
7 years, 5 months ago (2013-07-16 16:21:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/18927003/5001
7 years, 5 months ago (2013-07-16 20:53:33 UTC) #6
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-07-17 02:09:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/18927003/37001
7 years, 5 months ago (2013-07-17 03:06:05 UTC) #8
commit-bot: I haz the power
7 years, 5 months ago (2013-07-17 06:54:50 UTC) #9
Message was sent while issue was closed.
Change committed as 211986

Powered by Google App Engine
This is Rietveld 408576698