Reupload of "Flock master startup."

Reupload of "Flock master startup."

This was reverted because the path manipulation didn't work for internal masters. Original patchset here: https://chromiumcodereview.appspot.com/1883813003/.

BUG=588118
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299942

[ghost stip (do not use), 2016-04-14 21:01:14]

Description was changed from

==========
Reupload of "Flock master startup."

This was reverted because the path manipulation didn't work for internal
masters.

BUG=588118
==========

to

==========
Reupload of "Flock master startup."

This was reverted because the path manipulation didn't work for internal
masters.

BUG=588118
==========

[ghost stip (do not use), 2016-04-14 21:01:14]

stip@chromium.org changed reviewers:
+ dnj@chromium.org, pgervais@chromium.org

[ghost stip (do not use), 2016-04-14 21:23:41]

ptal. I've verified this launches working masters in build/ and build_internal/.

Note: this can't be launched until the zombie process issue is fixed.

https://codereview.chromium.org/1892643002/diff/20001/masters/master-common.mk
File masters/master-common.mk (left):

https://codereview.chromium.org/1892643002/diff/20001/masters/master-common.m...
masters/master-common.mk:14: GCLIENT = $(shell which gclient || echo
"$(TOPLEVEL_DIR)/../depot_tools/gclient")
we don't need to specify build/ here, but can just remove ../ instead

https://codereview.chromium.org/1892643002/diff/20001/masters/master-common.mk
File masters/master-common.mk (right):

https://codereview.chromium.org/1892643002/diff/20001/masters/master-common.m...
masters/master-common.mk:11: TOPLEVEL_DIR ?= ../../..
build_internal has this as ../../../, which is what caused the disparity in the
other patch

[ghost stip (do not use), 2016-04-14 21:24:10]

Description was changed from

==========
Reupload of "Flock master startup."

This was reverted because the path manipulation didn't work for internal
masters.

BUG=588118
==========

to

==========
Reupload of "Flock master startup."

This was reverted because the path manipulation didn't work for internal
masters. Original patchset here:
https://chromiumcodereview.appspot.com/1883813003/

BUG=588118
==========

[ghost stip (do not use), 2016-04-14 21:24:23]

Description was changed from

==========
Reupload of "Flock master startup."

This was reverted because the path manipulation didn't work for internal
masters. Original patchset here:
https://chromiumcodereview.appspot.com/1883813003/

BUG=588118
==========

to

==========
Reupload of "Flock master startup."

This was reverted because the path manipulation didn't work for internal
masters. Original patchset here:
https://chromiumcodereview.appspot.com/1883813003/.

BUG=588118
==========

[pgervais, 2016-04-14 21:26:47]

On 2016/04/14 21:23:41, stip wrote:
> ptal. I've verified this launches working masters in build/ and
build_internal/.
> 
> Note: this can't be launched until the zombie process issue is fixed.
> 
> https://codereview.chromium.org/1892643002/diff/20001/masters/master-common.mk
> File masters/master-common.mk (left):
> 
>
https://codereview.chromium.org/1892643002/diff/20001/masters/master-common.m...
> masters/master-common.mk:14: GCLIENT = $(shell which gclient || echo
> "$(TOPLEVEL_DIR)/../depot_tools/gclient")
> we don't need to specify build/ here, but can just remove ../ instead
> 
> https://codereview.chromium.org/1892643002/diff/20001/masters/master-common.mk
> File masters/master-common.mk (right):
> 
>
https://codereview.chromium.org/1892643002/diff/20001/masters/master-common.m...
> masters/master-common.mk:11: TOPLEVEL_DIR ?= ../../..
> build_internal has this as ../../../, which is what caused the disparity in
the
> other patch

lgtm

[ghost stip (do not use), 2016-04-14 23:23:30]

The CQ bit was checked by stip@chromium.org

[commit-bot: I haz the power, 2016-04-14 23:23:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1892643002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1892643002/20001

[commit-bot: I haz the power, 2016-04-14 23:27:56]

Description was changed from

==========
Reupload of "Flock master startup."

This was reverted because the path manipulation didn't work for internal
masters. Original patchset here:
https://chromiumcodereview.appspot.com/1883813003/.

BUG=588118
==========

to

==========
Reupload of "Flock master startup."

This was reverted because the path manipulation didn't work for internal
masters. Original patchset here:
https://chromiumcodereview.appspot.com/1883813003/.

BUG=588118

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299942
==========

[commit-bot: I haz the power, 2016-04-14 23:27:57]

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299942

[dsansome, 2016-04-15 05:44:18]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1883193003/ by dsansome@chromium.org.

The reason for reverting is: if [ -n $(ps -p$PID -o pid=) ]; then

This doesn't work at all.  Check the return code of ps or quote the string. 
http://o/293111.