Issue 18918002: Turn polymorphic calls using the same prototype monomorphic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18918002: Turn polymorphic calls using the same prototype monomorphic. (Closed)

Created:
7 years, 5 months ago by Toon Verwaest

Modified:
7 years, 5 months ago

Reviewers:
mvstanton, danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Turn polymorphic calls using the same prototype monomorphic. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15593

Patch Set 1 : #

Total comments: 2

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -10 lines)			Patch
	M	src/hydrogen.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	src/hydrogen.cc	View		3 chunks	+62 lines, -10 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

mvstanton

lgtm with one comment. https://chromiumcodereview.appspot.com/18918002/diff/9001/src/hydrogen.cc File src/hydrogen.cc (right): https://chromiumcodereview.appspot.com/18918002/diff/9001/src/hydrogen.cc#newcode6405 src/hydrogen.cc:6405: if (!ast_context()->IsEffect()) Push(call); Could you ...

7 years, 5 months ago (2013-07-10 12:48:14 UTC) #2

Toon Verwaest

https://chromiumcodereview.appspot.com/18918002/diff/9001/src/hydrogen.cc File src/hydrogen.cc (right): https://chromiumcodereview.appspot.com/18918002/diff/9001/src/hydrogen.cc#newcode6405 src/hydrogen.cc:6405: if (!ast_context()->IsEffect()) Push(call); This is boilerplate code that's all ...

7 years, 5 months ago (2013-07-10 13:04:03 UTC) #3

Toon Verwaest

7 years, 5 months ago (2013-07-10 13:05:46 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r15593 (presubmit successful).

Expand Messages | Collapse Messages