Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 1891563002: (Tiny) Temporarily enable hang report capture. (Closed)

Created:
4 years, 8 months ago by manzagop (departed)
Modified:
4 years, 8 months ago
CC:
chromium-reviews, Sigurður Ásgeirsson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporarily enable hang report capture. Overview: Browser process hangs are believed to be responsible for a large fraction of browser unclean shutdowns on Windows. This patch enables hang report capture to get visibility into the problem. Note: - Capture only occurs on canary Chrome for users with stats consent. - The plan is to release for a single day. BUG=478209 Committed: https://crrev.com/738c706910c84318db6f5309a1ff4c3584338722 Cr-Commit-Position: refs/heads/master@{#387473}

Patch Set 1 #

Patch Set 2 : Make GN consistent with GYP #

Patch Set 3 : Fix GN logic #

Patch Set 4 : Missing GN include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M build/common.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/kasko/kasko.gni View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 30 (14 generated)
manzagop (departed)
Hi! - This is to temporarily enable hang instrumentation. - I'm looking for a correctness ...
4 years, 8 months ago (2016-04-13 21:51:49 UTC) #3
Patrick Monette
lgtm
4 years, 8 months ago (2016-04-13 21:53:33 UTC) #4
jochen (gone - plz use gerrit)
why no corresponding gn change?
4 years, 8 months ago (2016-04-14 13:30:47 UTC) #5
manzagop (departed)
On 2016/04/14 13:30:47, jochen - slow wrote: > why no corresponding gn change? Thank you ...
4 years, 8 months ago (2016-04-14 16:05:13 UTC) #7
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-14 16:38:07 UTC) #8
manzagop (departed)
Thanks! Submitting.
4 years, 8 months ago (2016-04-14 18:53:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891563002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891563002/60001
4 years, 8 months ago (2016-04-14 18:54:35 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/6400)
4 years, 8 months ago (2016-04-14 19:39:52 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891563002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891563002/80001
4 years, 8 months ago (2016-04-14 19:50:51 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/54064)
4 years, 8 months ago (2016-04-14 21:53:59 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891563002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891563002/80001
4 years, 8 months ago (2016-04-14 21:56:44 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/54102)
4 years, 8 months ago (2016-04-14 22:18:28 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891563002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891563002/80001
4 years, 8 months ago (2016-04-14 22:31:53 UTC) #25
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 8 months ago (2016-04-14 23:35:35 UTC) #27
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/738c706910c84318db6f5309a1ff4c3584338722 Cr-Commit-Position: refs/heads/master@{#387473}
4 years, 8 months ago (2016-04-14 23:37:40 UTC) #29
manzagop (departed)
4 years, 8 months ago (2016-04-15 13:00:14 UTC) #30
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:80001) has been created in
https://chromiumcodereview.appspot.com/1892843002/ by manzagop@chromium.org.

The reason for reverting is: Single day experiment is complete..

Powered by Google App Engine
This is Rietveld 408576698