Issue 18887002: Add support to turn polymorphic loads from the same prototype into a monomorphic load.

Issue 18887002: Add support to turn polymorphic loads from the same prototype into a monomorphic load. (Closed)

Created:
7 years, 5 months ago by Toon Verwaest

Modified:
7 years, 5 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add support to turn polymorphic loads from the same prototype into a monomorphic load. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15569

Patch Set 2 : Delay casting prototype to JSObject until it is known to be one #

Patch Set 3 : Fix negative lookup #

Total comments: 4

Patch Set 4 : #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -3 lines)			Patch
	M	src/hydrogen.cc	View	1 2 3	1 chunk	+36 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yang

LGTM if comment addressed. https://chromiumcodereview.appspot.com/18887002/diff/5001/src/hydrogen.cc File src/hydrogen.cc (right): https://chromiumcodereview.appspot.com/18887002/diff/5001/src/hydrogen.cc#newcode4990 src/hydrogen.cc:4990: // Second chance: the property ...

7 years, 5 months ago (2013-07-09 09:54:47 UTC) #2

Toon Verwaest

Addressed nit. https://chromiumcodereview.appspot.com/18887002/diff/5001/src/hydrogen.cc File src/hydrogen.cc (right): https://chromiumcodereview.appspot.com/18887002/diff/5001/src/hydrogen.cc#newcode4990 src/hydrogen.cc:4990: // Second chance: the property is on ...

7 years, 5 months ago (2013-07-09 09:58:59 UTC) #3

Toon Verwaest

7 years, 5 months ago (2013-07-09 09:59:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r15569 (presubmit successful).

Expand Messages | Collapse Messages