Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18883003: add missing headers in gpu code (Closed)

Created:
7 years, 5 months ago by Mostyn Bramley-Moore
Modified:
7 years, 5 months ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

add missing headers in gpu code BUG=259043 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211355

Patch Set 1 #

Patch Set 2 : more missing headers #

Total comments: 3

Patch Set 3 : header sorting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M content/common/gpu/client/gl_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/gpu/input_handler_manager.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/gpu/input_handler_manager_client.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/gpu/input_handler_wrapper.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/memory_tracking.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Mostyn Bramley-Moore
@apatrick: PTAL this trivial patch...
7 years, 5 months ago (2013-07-11 13:32:26 UTC) #1
apatrick_chromium
https://codereview.chromium.org/18883003/diff/2001/content/renderer/gpu/input_handler_wrapper.cc File content/renderer/gpu/input_handler_wrapper.cc (right): https://codereview.chromium.org/18883003/diff/2001/content/renderer/gpu/input_handler_wrapper.cc#newcode8 content/renderer/gpu/input_handler_wrapper.cc:8: #include "content/renderer/gpu/input_handler_wrapper.h" We like to make the header file ...
7 years, 5 months ago (2013-07-11 18:41:06 UTC) #2
Mostyn Bramley-Moore
https://codereview.chromium.org/18883003/diff/2001/content/renderer/gpu/input_handler_wrapper.cc File content/renderer/gpu/input_handler_wrapper.cc (right): https://codereview.chromium.org/18883003/diff/2001/content/renderer/gpu/input_handler_wrapper.cc#newcode8 content/renderer/gpu/input_handler_wrapper.cc:8: #include "content/renderer/gpu/input_handler_wrapper.h" On 2013/07/11 18:41:06, apatrick_chromium wrote: > We ...
7 years, 5 months ago (2013-07-11 18:45:17 UTC) #3
Mostyn Bramley-Moore
https://codereview.chromium.org/18883003/diff/2001/content/renderer/gpu/input_handler_wrapper.cc File content/renderer/gpu/input_handler_wrapper.cc (right): https://codereview.chromium.org/18883003/diff/2001/content/renderer/gpu/input_handler_wrapper.cc#newcode8 content/renderer/gpu/input_handler_wrapper.cc:8: #include "content/renderer/gpu/input_handler_wrapper.h" On 2013/07/11 18:45:17, Mostyn Bramley-Moore wrote: > ...
7 years, 5 months ago (2013-07-11 18:53:05 UTC) #4
apatrick_chromium
lgtm
7 years, 5 months ago (2013-07-11 19:07:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/18883003/8002
7 years, 5 months ago (2013-07-12 03:33:37 UTC) #6
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) media_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=68680
7 years, 5 months ago (2013-07-12 03:57:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/18883003/8002
7 years, 5 months ago (2013-07-12 07:12:22 UTC) #8
commit-bot: I haz the power
7 years, 5 months ago (2013-07-12 07:54:27 UTC) #9
Message was sent while issue was closed. 
Change committed as 211355

Powered by Google App Engine
This is Rietveld 408576698