Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
Help
|
Chromium Project
|
Gerrit Changes
|
Sign in
(66)
Issues
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
18881006
: Revert "Allow NORMAL ICs to go polymorphic." (Closed)
Created:
7 years, 6 months ago by
Toon Verwaest
Modified:
7 years, 6 months ago
Reviewers:
danno
CC:
v8-dev
Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge
Visibility:
Public.
More Reviews
Description
Revert "Allow NORMAL ICs to go polymorphic." BUG=
R=danno@chromium.org
Committed:
https://code.google.com/p/v8/source/detail?r=15604
Patch Set 1
#
Created:
7 years, 6 months ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+12 lines, -8 lines
)
Patch
M
src/ic.cc
View
3 chunks
+12 lines, -8 lines
0 comments
Download
Messages
Total messages: 3 (0 generated)
Expand Messages
|
Collapse Messages
Toon Verwaest
PTAL
7 years, 6 months ago (2013-07-10 15:59:06 UTC)
#1
PTAL
danno
lgtm
7 years, 6 months ago (2013-07-10 15:59:36 UTC)
#2
lgtm
Toon Verwaest
Committed patchset #1 manually as r15604 (presubmit successful).
7 years, 6 months ago (2013-07-10 16:00:54 UTC)
#3
Message was sent while issue was closed.
Committed patchset #1 manually as r15604 (presubmit successful).
Expand Messages
|
Collapse Messages
Issue 18881006: Revert "Allow NORMAL ICs to go polymorphic." (Closed)
Created 7 years, 6 months ago by Toon Verwaest
Modified 7 years, 6 months ago
Reviewers: danno
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Comments: 0
This is Rietveld
408576698