Issue 18881003: include missing headers in skia/ext/analysis_canvas.{h,cc}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18881003: include missing headers in skia/ext/analysis_canvas.{h,cc} (Closed)

Created:
7 years, 5 months ago by Mostyn Bramley-Moore

Modified:
7 years, 5 months ago

Reviewers:
Tom Hudson, tomhudson

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

include missing headers in skia/ext/analysis_canvas.{h,cc} skia/ext/analysis_canvas.h uses the OVERRIDE macro, but does not include the header file that defines it. And analysis_canvas.cc lacks the header for DCHECK. BUG=259043 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212042

Patch Set 1 #

Patch Set 2 : add header for DHCECK to analysis_canvas.cc #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	skia/ext/analysis_canvas.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	skia/ext/analysis_canvas.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/18881003/3001

7 years, 5 months ago (2013-07-17 09:43:31 UTC) #3

Message was sent while issue was closed.

Change committed as 212042

Expand Messages | Collapse Messages