Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1517)

Unified Diff: chrome/browser/extensions/activity_log/counting_policy.h

Issue 18878009: Add functions to clean URLs from the activity log (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added counting policy Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/activity_log/counting_policy.h
diff --git a/chrome/browser/extensions/activity_log/counting_policy.h b/chrome/browser/extensions/activity_log/counting_policy.h
index 3911bcad3ff47a8b398f61fa601188de1ae02c32..09a739f04a6392ca4880643dabaae128ab842fa9 100644
--- a/chrome/browser/extensions/activity_log/counting_policy.h
+++ b/chrome/browser/extensions/activity_log/counting_policy.h
@@ -36,6 +36,9 @@ class CountingPolicy : public ActivityLogDatabasePolicy {
retention_time_ = delta;
}
+ // Clean the URL data stored for this policy.
+ virtual void RemoveURLs(const std::vector<GURL>&);
mvrable 2013/08/26 20:38:50 virtual void RemoveURLs(const std::vector<GURL>&)
karenlees 2013/08/26 22:58:36 Done.
+
// The main database table, and the name for a read-only view that
// decompresses string values for easier parsing.
static const char* kTableName;
@@ -66,6 +69,10 @@ class CountingPolicy : public ActivityLogDatabasePolicy {
const std::string& extension_id,
const int days_ago);
+ // The implementation of RemoveURLs; this must only run on the database
+ // thread.
+ virtual void DoRemoveURLs(const std::vector<GURL>& restrict_urls);
mvrable 2013/08/26 20:38:50 Doesn't need to be virtual since the method is pri
karenlees 2013/08/26 22:58:36 Done - but should I make it protected instead, inc
mvrable 2013/08/27 17:17:37 Personal opinion: it doesn't need to be as we can
+
// Cleans old records from the activity log database.
bool CleanOlderThan(sql::Connection* db, const base::Time& cutoff);

Powered by Google App Engine
This is Rietveld 408576698