Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: chrome/browser/history/DEPS

Issue 18878009: Add functions to clean URLs from the activity log (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added counting policy Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 include_rules = [ 1 include_rules = [
2 # History is being made into a Browser Component, so we have these 2 # History is being made into a Browser Component, so we have these
3 # basic rules followed by temporary exceptions. Please don't 3 # basic rules followed by temporary exceptions. Please don't
4 # add to the list of exceptions! 4 # add to the list of exceptions!
5 "-chrome/browser", 5 "-chrome/browser",
6 "+chrome/browser/chrome_notification_types.h", 6 "+chrome/browser/chrome_notification_types.h",
7 "+chrome/browser/common", 7 "+chrome/browser/common",
8 "+chrome/browser/favicon", 8 "+chrome/browser/favicon",
9 "+chrome/browser/history", 9 "+chrome/browser/history",
10 10
(...skipping 28 matching lines...) Expand all
39 "!chrome/browser/signin/profile_oauth2_token_service_factory.h", 39 "!chrome/browser/signin/profile_oauth2_token_service_factory.h",
40 "!chrome/browser/signin/token_service_factory.h", 40 "!chrome/browser/signin/token_service_factory.h",
41 "!chrome/browser/sync/profile_sync_service.h", 41 "!chrome/browser/sync/profile_sync_service.h",
42 "!chrome/browser/sync/profile_sync_service_factory.h", 42 "!chrome/browser/sync/profile_sync_service_factory.h",
43 "!chrome/browser/ui/browser.h", 43 "!chrome/browser/ui/browser.h",
44 "!chrome/browser/ui/browser_finder.h", 44 "!chrome/browser/ui/browser_finder.h",
45 "!chrome/browser/search_engines/template_url_id.h", 45 "!chrome/browser/search_engines/template_url_id.h",
46 "!chrome/browser/ui/profile_error_dialog.h", 46 "!chrome/browser/ui/profile_error_dialog.h",
47 "!chrome/browser/ui/webui/ntp/most_visited_handler.h", 47 "!chrome/browser/ui/webui/ntp/most_visited_handler.h",
48 "!chrome/browser/ui/webui/ntp/new_tab_ui.h", 48 "!chrome/browser/ui/webui/ntp/new_tab_ui.h",
49 # TODO(karenlees): ask history team the best place to use the activity log we
50 # are not supposed to be adding dependencies here. This was only added so I
51 # could upload the changes to code review to demonstrate the changes I am
52 # trying to make.
53 "!chrome/browser/extensions/activity_log/activity_log.h"
49 ] 54 ]
50 55
51 specific_include_rules = { 56 specific_include_rules = {
52 # Browser tests, by definition, need access to the browser objects. 57 # Browser tests, by definition, need access to the browser objects.
53 '.*_(api|browser|)test\.cc': [ 58 '.*_(api|browser|)test\.cc': [
54 "+chrome/browser", 59 "+chrome/browser",
55 ], 60 ],
56 # TODO(erikwright): Bring this list to zero. 61 # TODO(erikwright): Bring this list to zero.
57 # 62 #
58 # Do not add to the list of temporarily-allowed dependencies below, 63 # Do not add to the list of temporarily-allowed dependencies below,
59 # and please do not introduce more #includes of these files. 64 # and please do not introduce more #includes of these files.
60 '.*_[a-z]*test\.cc': [ 65 '.*_[a-z]*test\.cc': [
61 "!chrome/browser/bookmarks/bookmark_utils.h", 66 "!chrome/browser/bookmarks/bookmark_utils.h",
62 ] 67 ]
63 } 68 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698