Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issue 18878002: Refactoring on DOM/Promises (Closed)

Created:
7 years, 5 months ago by yhirano
Modified:
7 years, 5 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, Nils Barth (inactive), jsbell+bindings_chromium.org, eae+blinkwatch, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, haraken, Nate Chapin, do-not-use
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Refactoring on DOM/Promises We are implementing DOM/promises[1]. This CL adds some layout tests and does some refactoring. We change the status of "Promise" runtime enabled flag from test to experimental. [1]: http://dom.spec.whatwg.org/#promises R=abarth BUG=243345 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153798

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -109 lines) Patch
M LayoutTests/fast/js/Promise-already-fulfilled.html View 1 chunk +3 lines, -1 line 0 comments Download
A + LayoutTests/fast/js/Promise-already-rejected.html View 1 chunk +8 lines, -6 lines 0 comments Download
A + LayoutTests/fast/js/Promise-already-rejected-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/js/Promise-already-resolved.html View 1 chunk +7 lines, -2 lines 0 comments Download
A + LayoutTests/fast/js/Promise-already-resolved-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A LayoutTests/fast/js/Promise-resolve-chain.html View 1 chunk +50 lines, -0 lines 0 comments Download
A + LayoutTests/fast/js/Promise-resolve-chain-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/v8/custom/V8PromiseCustom.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/bindings/v8/custom/V8PromiseCustom.cpp View 8 chunks +27 lines, -95 lines 1 comment Download
M Source/core/page/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
yhirano
Hi, can you review this CL? I changed the "Promise" flag status from test to ...
7 years, 5 months ago (2013-07-09 05:06:35 UTC) #1
yhirano
Sorry, the issue description was wrong. I fixed it.
7 years, 5 months ago (2013-07-09 05:38:55 UTC) #2
abarth-chromium
On 2013/07/09 05:06:35, yhirano wrote: > I changed the "Promise" flag status from test to ...
7 years, 5 months ago (2013-07-09 17:47:22 UTC) #3
abarth-chromium
lgtm https://codereview.chromium.org/18878002/diff/1/Source/bindings/v8/custom/V8PromiseCustom.cpp File Source/bindings/v8/custom/V8PromiseCustom.cpp (right): https://codereview.chromium.org/18878002/diff/1/Source/bindings/v8/custom/V8PromiseCustom.cpp#newcode54 Source/bindings/v8/custom/V8PromiseCustom.cpp:54: v8::Local<v8::Function> createClosure(v8::FunctionCallback function, v8::Handle<v8::Value> environment) This seems like ...
7 years, 5 months ago (2013-07-09 17:49:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/18878002/1
7 years, 5 months ago (2013-07-09 17:49:42 UTC) #5
commit-bot: I haz the power
7 years, 5 months ago (2013-07-09 18:54:09 UTC) #6
Message was sent while issue was closed.
Change committed as 153798

Powered by Google App Engine
This is Rietveld 408576698