Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 18868009: Generate the lists of localization files instead of hardcoding them. (Closed)

Created:
7 years, 5 months ago by alexeypa (please no reviews)
Modified:
7 years, 5 months ago
Reviewers:
garykac
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Generate the lists of localization files instead of hardcoding them. This CL modifies remoting/tools/localize.py script such that it can: - be invoked via 'pymod_do_main' filter. - generate a separate output file for each locale/language. - produce the list of output files for given set of parameters. remoting.gyp now generates the lists of .pak and message.json files invoking the script via 'pymod_do_main' filter. 'pymod_do_main' is necessary to pass paths unaltered between GYP and python. The script was also renamed to remoting/tools/build/remoting_localize.py to avoid potential name clashes since the script is globally visible now. TBR is for the DEPS changes only. TBR=cpu@chromium.org BUG=155204 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211227

Patch Set 1 #

Patch Set 2 : - #

Total comments: 2

Patch Set 3 : CR feedback #

Patch Set 4 : rebased #

Patch Set 5 : Updating DEPS and path to jinja2. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -929 lines) Patch
M build/gyp_chromium View 1 1 chunk +1 line, -0 lines 0 comments Download
M remoting/remoting.gyp View 1 2 3 6 chunks +33 lines, -146 lines 0 comments Download
M remoting/tools/DEPS View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
A + remoting/tools/build/DEPS View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
A + remoting/tools/build/remoting_localize.py View 1 2 3 4 8 chunks +118 lines, -63 lines 0 comments Download
M remoting/tools/localize.py View 1 1 chunk +0 lines, -718 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
alexeypa (please no reviews)
PTAL.
7 years, 5 months ago (2013-07-09 23:56:49 UTC) #1
garykac
lgtm Nice. lgtm. https://codereview.chromium.org/18868009/diff/13001/remoting/tools/build/remoting_localize.py File remoting/tools/build/remoting_localize.py (right): https://codereview.chromium.org/18868009/diff/13001/remoting/tools/build/remoting_localize.py#newcode13 remoting/tools/build/remoting_localize.py:13: - Each NAME=VALUE define ('-d') can ...
7 years, 5 months ago (2013-07-10 23:52:21 UTC) #2
alexeypa (please no reviews)
https://codereview.chromium.org/18868009/diff/13001/remoting/tools/build/remoting_localize.py File remoting/tools/build/remoting_localize.py (right): https://codereview.chromium.org/18868009/diff/13001/remoting/tools/build/remoting_localize.py#newcode13 remoting/tools/build/remoting_localize.py:13: - Each NAME=VALUE define ('-d') can be accesses as ...
7 years, 5 months ago (2013-07-11 18:05:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/18868009/23002
7 years, 5 months ago (2013-07-11 18:09:35 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 5 months ago (2013-07-11 18:47:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/18868009/46001
7 years, 5 months ago (2013-07-11 19:28:07 UTC) #6
commit-bot: I haz the power
7 years, 5 months ago (2013-07-11 22:01:37 UTC) #7
Message was sent while issue was closed.
Change committed as 211227

Powered by Google App Engine
This is Rietveld 408576698