Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 18863004: add missing headers in child tracing code (Closed)

Created:
7 years, 5 months ago by Mostyn Bramley-Moore
Modified:
7 years, 5 months ago
Reviewers:
Charlie Reis, nduca, jbauman
CC:
chromium-reviews, dsinclair+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

add missing headers in components/tracing/child_trace_message_filter.h and content/child/child_resource_message_filter.cc BUG=259043 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211542

Patch Set 1 #

Patch Set 2 : more missing headers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M components/tracing/child_trace_message_filter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/child/child_resource_message_filter.cc View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Mostyn Bramley-Moore
@jbauman: PTAL at this trivial patch...
7 years, 5 months ago (2013-07-11 09:33:58 UTC) #1
jbauman
lgtm
7 years, 5 months ago (2013-07-11 21:00:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/18863004/2001
7 years, 5 months ago (2013-07-12 03:33:48 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=14929
7 years, 5 months ago (2013-07-12 03:50:19 UTC) #4
Mostyn Bramley-Moore
@creis: can you take a quick look at content/child/child_resource_message_filter.cc ?
7 years, 5 months ago (2013-07-12 07:11:20 UTC) #5
Charlie Reis
Sure. content/child/child_resource_message_filter.cc LGTM.
7 years, 5 months ago (2013-07-12 17:18:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/18863004/2001
7 years, 5 months ago (2013-07-12 18:01:45 UTC) #7
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=148616
7 years, 5 months ago (2013-07-12 19:27:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/18863004/2001
7 years, 5 months ago (2013-07-12 19:30:38 UTC) #9
commit-bot: I haz the power
7 years, 5 months ago (2013-07-13 04:31:53 UTC) #10
Message was sent while issue was closed.
Change committed as 211542

Powered by Google App Engine
This is Rietveld 408576698