Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: Source/core/css/CSSFontFaceSource.h

Issue 18856015: [oilpan] Move CSSFontFace to the managed heap (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/CSSFontFaceSource.h
diff --git a/Source/core/css/CSSFontFaceSource.h b/Source/core/css/CSSFontFaceSource.h
index 9e9f9ea9c3a4c1f19b66c4208e85920c7b5cc3fb..590b0b3d1db247d6f491d31cba425aa2a56ea2a9 100644
--- a/Source/core/css/CSSFontFaceSource.h
+++ b/Source/core/css/CSSFontFaceSource.h
@@ -55,7 +55,7 @@ public:
const AtomicString& string() const { return m_string; }
- void setFontFace(CSSFontFace* face) { m_face = face; }
+ void setFontFace(Handle<CSSFontFace> face) { m_face = face.raw(); }
virtual void fontLoaded(CachedFont*);
@@ -78,6 +78,7 @@ private:
AtomicString m_string; // URI for remote, built-in font name for local.
CachedResourceHandle<CachedFont> m_font; // For remote fonts, a pointer to our cached resource.
+ // FIXME(oilpan): Move CSSFontFaceSource to the managed heap and change this to a Member.
CSSFontFace* m_face; // Our owning font face.
Vyacheslav Egorov (Google) 2013/07/10 10:59:58 I think you can make it a member right away. There
haraken 2013/07/10 11:38:41 My concern is that using Members in not heap alloc
HashMap<unsigned, RefPtr<SimpleFontData> > m_fontDataTable; // The hash key is composed of size synthetic styles.

Powered by Google App Engine
This is Rietveld 408576698