Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6900)

Unified Diff: chrome/common/extensions/permissions/permissions_data.cc

Issue 18854021: Making the extension permissions dialog scrollable, when needed (adding expandable sections for thi… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Polish Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/permissions/permissions_data.cc
diff --git a/chrome/common/extensions/permissions/permissions_data.cc b/chrome/common/extensions/permissions/permissions_data.cc
index 450c2ea5e4b1b2f0ab1d0326a3ae3bc0c8a57566..c0d495228f84dbc233c30d37dd40bd1b919fbd46 100644
--- a/chrome/common/extensions/permissions/permissions_data.cc
+++ b/chrome/common/extensions/permissions/permissions_data.cc
@@ -444,6 +444,18 @@ std::vector<string16> PermissionsData::GetPermissionMessageStrings(
}
// static
+std::vector<string16> PermissionsData::GetPermissionMessageDetailsStrings(
+ const Extension* extension) {
+ base::AutoLock auto_lock(extension->permissions_data()->runtime_lock_);
+ if (ShouldSkipPermissionWarnings(extension)) {
+ return std::vector<string16>();
+ } else {
+ return GetActivePermissions(extension)->GetWarningMessagesDetails(
+ extension->GetType());
+ }
+}
+
+// static
bool PermissionsData::CanExecuteScriptOnPage(const Extension* extension,
const GURL& document_url,
const GURL& top_frame_url,

Powered by Google App Engine
This is Rietveld 408576698