Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4236)

Unified Diff: chrome/common/extensions/permissions/permission_message.h

Issue 18854021: Making the extension permissions dialog scrollable, when needed (adding expandable sections for thi… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Polish Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/permissions/permission_message.h
diff --git a/chrome/common/extensions/permissions/permission_message.h b/chrome/common/extensions/permissions/permission_message.h
index ad814ae6f53fda137844d85aed63f2f5fc8ed793..9098dc13c1347606cfdffc73bd8b4f210375b525 100644
--- a/chrome/common/extensions/permissions/permission_message.h
+++ b/chrome/common/extensions/permissions/permission_message.h
@@ -76,6 +76,7 @@ class PermissionMessage {
// Creates the corresponding permission message.
PermissionMessage(ID id, const string16& message);
+ PermissionMessage(ID id, const string16& message, const string16& details);
~PermissionMessage();
// Gets the id of the permission message, which can be used in UMA
@@ -86,6 +87,11 @@ class PermissionMessage {
// the message will be empty for message types TYPE_NONE and TYPE_UNKNOWN.
const string16& message() const { return message_; }
+ // Gets a localized message describing the details for this permission. Please
+ // note that the message will be empty for message types TYPE_NONE and
+ // TYPE_UNKNOWN.
+ const string16& details() const { return details_; }
+
// Comparator to work with std::set.
bool operator<(const PermissionMessage& that) const {
return id_ < that.id_;
@@ -94,6 +100,7 @@ class PermissionMessage {
private:
ID id_;
string16 message_;
+ string16 details_;
};
typedef std::vector<PermissionMessage> PermissionMessages;

Powered by Google App Engine
This is Rietveld 408576698