Issue 18854018: ARM: Do not omit the write-barrier if the input value is a smi.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18854018: ARM: Do not omit the write-barrier if the input value is a smi. (Closed)

Created:
7 years, 5 months ago by Toon Verwaest

Modified:
7 years, 5 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

ARM: Do not omit the write-barrier if the input value is a smi. The input value isn't what is written into the field if the representation is double. A heap-number is written to the field instead; which requires a write-barrier. BUG=chromium:254570 R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15573

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -6 lines)			Patch
	M	src/arm/stub-cache-arm.cc	View		2 chunks	+0 lines, -6 lines	0 comments	Download

Total messages: 3 (0 generated)

Toon Verwaest

7 years, 5 months ago (2013-07-09 12:32:04 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r15573 (presubmit successful).