Issue 18851005: Print time of long running hook actions

Issue 18851005: Print time of long running hook actions (Closed)

Created:
7 years, 5 months ago by Isaac (away)

Modified:
7 years, 5 months ago

Reviewers:
iannucci, M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

Print time of long running hook actions We can use this to evaluate the usefulness of making hooks run in parallel. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=211446

Patch Set 1 : #

Patch Set 2 : Pretty print command, escape for shells. #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -5 lines)			Patch
M	gclient.py	View	1	3 chunks	+7 lines, -0 lines	0 comments	Download
M	gclient_utils.py	View	1	3 chunks	+7 lines, -1 line	0 comments	Download
M	tests/gclient_utils_test.py	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

Isaac (away)

Prints messages like: ________ running '/usr/bin/python src/build/gyp_chromium' in '/media/ssdb/code/chromium' Updating projects from gyp files... Hook ...

7 years, 5 months ago (2013-07-12 00:14:22 UTC) #1

Isaac (away)

Thanks for the review -- could you take another quick look? I adding another minor ...

7 years, 5 months ago (2013-07-12 18:52:51 UTC) #5

M-A Ruel

lgtm it's possible it has side effects, I know buildbot parses gclient ouput. So just ...

7 years, 5 months ago (2013-07-12 19:18:32 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/18851005/10001

7 years, 5 months ago (2013-07-12 19:40:38 UTC) #8

Message was sent while issue was closed.

Change committed as 211446

Expand Messages | Collapse Messages