Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 18850006: retry r210334 with fix for android (Closed)

Created:
7 years, 5 months ago by Evan Stade
Modified:
7 years, 5 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, Raman Kakilate, benquan, tfarina, ahutter, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

retry r210334 with fix for android requestAutocomplete: Wallet interstitial on Views. 1. "generating card..." 2. "card generated" (only on first run) BUG=243571 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=210460

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+447 lines, -122 lines) Patch
M chrome/browser/ui/autofill/autofill_dialog_controller.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 4 chunks +62 lines, -4 lines 1 comment Download
M chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc View 5 chunks +61 lines, -2 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_types.h View 2 chunks +25 lines, -0 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_types.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/autofill/mock_autofill_dialog_controller.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/autofill/mock_autofill_dialog_controller.cc View 3 chunks +10 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/autofill/autofill_dialog_views.h View 5 chunks +46 lines, -1 line 0 comments Download
M chrome/browser/ui/views/autofill/autofill_dialog_views.cc View 10 chunks +226 lines, -111 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Evan Stade
https://codereview.chromium.org/18850006/diff/1/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc File chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc (right): https://codereview.chromium.org/18850006/diff/1/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc#newcode766 chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:766: #if !defined(OS_ANDROID) here's the fix.
7 years, 5 months ago (2013-07-08 19:47:28 UTC) #1
Dan Beam
slgtm
7 years, 5 months ago (2013-07-08 19:49:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/18850006/1
7 years, 5 months ago (2013-07-08 20:22:08 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-08 23:48:52 UTC) #4
Message was sent while issue was closed.
Change committed as 210460

Powered by Google App Engine
This is Rietveld 408576698