Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: ui/gfx/font_list.h

Issue 18848002: Shows Japanese and English mixed queries correctly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Disables the test on Android. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/gtest/filter/ui_unittests_disabled ('k') | ui/gfx/font_list.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/font_list.h
diff --git a/ui/gfx/font_list.h b/ui/gfx/font_list.h
index d070b5b588c2f63f834bc31c0f3dbac15f14d72e..f573c1e1c6d5c2e27136bec9c8488db9e46da980 100644
--- a/ui/gfx/font_list.h
+++ b/ui/gfx/font_list.h
@@ -8,6 +8,7 @@
#include <string>
#include <vector>
+#include "base/gtest_prod_util.h"
#include "ui/base/ui_export.h"
#include "ui/gfx/font.h"
@@ -57,6 +58,14 @@ class UI_EXPORT FontList {
// given font |size| in pixels.
FontList DeriveFontListWithSize(int size) const;
+ // Returns the height of this font list, which is max(ascent) + max(descent)
+ // for all the fonts in the font list.
+ int GetHeight() const;
+
+ // Returns the baseline of this font list, which is max(baseline) for all the
+ // fonts in the font list.
+ int GetBaseline() const;
+
// Returns the |gfx::Font::FontStyle| style flags for this font list.
int GetFontStyle() const;
@@ -69,6 +78,8 @@ class UI_EXPORT FontList {
const std::vector<Font>& GetFonts() const;
private:
+ FRIEND_TEST_ALL_PREFIXES(FontListTest, Fonts_GetHeight_GetBaseline);
+
// A vector of Font. If FontList is constructed with font description string,
// |fonts_| is not initialized during construction. Instead, it is computed
// lazily when user asked to get the font vector.
@@ -81,6 +92,10 @@ class UI_EXPORT FontList {
// |font_description_string_| is not initialized during construction. Instead,
// it is computed lazily when user asked to get the font description string.
mutable std::string font_description_string_;
+
+ // The cached common height and baseline of the fonts in the font list.
+ mutable int common_height_;
+ mutable int common_baseline_;
};
} // namespace gfx
« no previous file with comments | « build/android/pylib/gtest/filter/ui_unittests_disabled ('k') | ui/gfx/font_list.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698