Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 18834003: Revert "Updating the mapped_file_avoid_mmap_posix implementation." (Closed)

Created:
7 years, 5 months ago by qsr
Modified:
7 years, 5 months ago
Reviewers:
gavinp
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, pauljensen
Visibility:
Public.

Description

Revert "Updating the mapped_file_avoid_mmap_posix implementation." This reverts commit d539da3c0f41200aac7cc660c4712d905b73d8a5. The SEGV causes issue with the android watchdog. R=gavinp@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211145

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -314 lines) Patch
M net/disk_cache/backend_unittest.cc View 1 chunk +1 line, -5 lines 0 comments Download
M net/disk_cache/disk_cache_test_util.h View 1 chunk +0 lines, -3 lines 0 comments Download
M net/disk_cache/disk_cache_test_util.cc View 2 chunks +1 line, -5 lines 0 comments Download
M net/disk_cache/mapped_file.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/disk_cache/mapped_file_avoid_mmap_posix.cc View 3 chunks +20 lines, -250 lines 0 comments Download
M net/disk_cache/mapped_file_unittest.cc View 1 chunk +0 lines, -51 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
qsr
7 years, 5 months ago (2013-07-11 08:01:10 UTC) #1
gavinp
LGTM, with sadness.
7 years, 5 months ago (2013-07-11 14:19:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/18834003/1
7 years, 5 months ago (2013-07-11 14:20:51 UTC) #3
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=147975
7 years, 5 months ago (2013-07-11 15:30:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/18834003/1
7 years, 5 months ago (2013-07-11 15:37:10 UTC) #5
commit-bot: I haz the power
Change committed as 211145
7 years, 5 months ago (2013-07-11 17:27:24 UTC) #6
pauljensen
7 years, 5 months ago (2013-07-11 19:48:23 UTC) #7
Message was sent while issue was closed.
Is there a bug related to this?  I didn't see the original bug reopened.

Powered by Google App Engine
This is Rietveld 408576698