Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: build/android/tombstones.py

Issue 18826012: Telemetry / Android: symbolize crashstack. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/chrome/adb_commands.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/tombstones.py
diff --git a/build/android/tombstones.py b/build/android/tombstones.py
index b2dbfb66bea74deb9222d35f2d8c258bb70bb99f..b85a82bd7d4c763c3039cd192e6ce2e804fbf142 100755
--- a/build/android/tombstones.py
+++ b/build/android/tombstones.py
@@ -163,15 +163,15 @@ def _GetTombstonesForDevice(adb, options):
def main():
parser = optparse.OptionParser()
+ parser.add_option('--device',
+ help='The serial number of the device. If not specified '
+ 'will use all devices.')
parser.add_option('-a', '--all-tombstones', action='store_true',
- dest='all_tombstones', default=False,
help="""Resolve symbols for all tombstones, rather than just
the most recent""")
parser.add_option('-s', '--stack', action='store_true',
- dest='stack', default=False,
help='Also include symbols for stack data')
parser.add_option('-w', '--wipe-tombstones', action='store_true',
- dest='wipe_tombstones', default=False,
help='Erase all tombstones from device after processing')
parser.add_option('-j', '--jobs', type='int',
default=4,
@@ -179,7 +179,11 @@ def main():
'crash stacks.')
options, args = parser.parse_args()
- devices = android_commands.GetAttachedDevices()
+ if options.device:
+ devices = [options.device]
+ else:
+ devices = android_commands.GetAttachedDevices()
+
tombstones = []
for device in devices:
adb = android_commands.AndroidCommands(device)
« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/chrome/adb_commands.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698