Telemetry / Android: symbolize crashstack.

Telemetry / Android: symbolize crashstack.

Use all the tools to get as much information as possible:
- print the logcat
- try to symbolize it
- try to symbolize tombstones

BUG=223572
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211459

[bulach, 2013-07-12 08:50:33]

ptal

[tonyg, 2013-07-12 15:33:29]

lgtm

Thanks for hooking this up!

https://codereview.chromium.org/18826012/diff/1/tools/telemetry/telemetry/cor...
File tools/telemetry/telemetry/core/chrome/android_browser_backend.py (right):

https://codereview.chromium.org/18826012/diff/1/tools/telemetry/telemetry/cor...
tools/telemetry/telemetry/core/chrome/android_browser_backend.py:268:
chrome_src_dir = os.path.abspath(
util.GetChromiumSrcDir()

https://codereview.chromium.org/18826012/diff/1/tools/telemetry/telemetry/pag...
File tools/telemetry/telemetry/page/page_runner.py (left):

https://codereview.chromium.org/18826012/diff/1/tools/telemetry/telemetry/pag...
tools/telemetry/telemetry/page/page_runner.py:238: if not options.show_stdout:
That was weird

[bulach, 2013-07-12 15:51:26]

thanks tony! comments addressing, CQing..

https://codereview.chromium.org/18826012/diff/1/tools/telemetry/telemetry/cor...
File tools/telemetry/telemetry/core/chrome/android_browser_backend.py (right):

https://codereview.chromium.org/18826012/diff/1/tools/telemetry/telemetry/cor...
tools/telemetry/telemetry/core/chrome/android_browser_backend.py:268:
chrome_src_dir = os.path.abspath(
On 2013/07/12 15:33:30, tonyg wrote:
> util.GetChromiumSrcDir()

much nicer! thanks.

https://codereview.chromium.org/18826012/diff/1/tools/telemetry/telemetry/pag...
File tools/telemetry/telemetry/page/page_runner.py (left):

https://codereview.chromium.org/18826012/diff/1/tools/telemetry/telemetry/pag...
tools/telemetry/telemetry/page/page_runner.py:238: if not options.show_stdout:
On 2013/07/12 15:33:30, tonyg wrote:
> That was weird

:)

[commit-bot: I haz the power, 2013-07-12 15:51:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bulach@chromium.org/18826012/5001

[commit-bot: I haz the power, 2013-07-12 21:11:19]

Change committed as 211459

[tonyg, 2013-07-12 22:52:41]

https://codereview.chromium.org/18826012/diff/1/tools/telemetry/telemetry/pag...
File tools/telemetry/telemetry/page/page_runner.py (left):

https://codereview.chromium.org/18826012/diff/1/tools/telemetry/telemetry/pag...
tools/telemetry/telemetry/page/page_runner.py:238: if not options.show_stdout:
On 2013/07/12 15:51:27, bulach wrote:
> On 2013/07/12 15:33:30, tonyg wrote:
> > That was weird
> 
> :)

Sorry, I realized why this was there now. The idea is that if you are already
running with --show-stdout, then you don't need to call GetStandardOutput()
because the stdout is already being output.

This block specifically says, even if you are not using --show-stdout, we want
to show it in the case of a tab crash.

Since the bots do not pass --show-stdout, with this change we'll never output
stacks on the bots.

The easiest thing to do is probably just to put it back the way it was. The
right thing to do is probably to separate out functions for GetStandardOutput()
and GetStackTrace() instead of misusing GetStandardOutput() on android.

[bulach, 2013-07-15 09:35:01]

On 2013/07/12 22:52:41, tonyg wrote:
>
https://codereview.chromium.org/18826012/diff/1/tools/telemetry/telemetry/pag...
> File tools/telemetry/telemetry/page/page_runner.py (left):
> 
>
https://codereview.chromium.org/18826012/diff/1/tools/telemetry/telemetry/pag...
> tools/telemetry/telemetry/page/page_runner.py:238: if not options.show_stdout:
> On 2013/07/12 15:51:27, bulach wrote:
> > On 2013/07/12 15:33:30, tonyg wrote:
> > > That was weird
> > 
> > :)
> 
> Sorry, I realized why this was there now. The idea is that if you are already
> running with --show-stdout, then you don't need to call GetStandardOutput()
> because the stdout is already being output.
> 
> This block specifically says, even if you are not using --show-stdout, we want
> to show it in the case of a tab crash.
> 
> Since the bots do not pass --show-stdout, with this change we'll never output
> stacks on the bots.
> 
> The easiest thing to do is probably just to put it back the way it was. The
> right thing to do is probably to separate out functions for
GetStandardOutput()
> and GetStackTrace() instead of misusing GetStandardOutput() on android.

ahn, that makes sense! I'll prepare a patch in a bit, sorry about the churn.