Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Unified Diff: public/web/WebViewClient.h

Issue 18822004: Extension Error Piping - Blink: WebKit Side (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/core/page/Chrome.cpp ('K') | « public/testing/WebTestProxy.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/web/WebViewClient.h
diff --git a/public/web/WebViewClient.h b/public/web/WebViewClient.h
index 7056dd64b7dc427d90fcf9c4d787ef0943c3f5e8..a1374bbc8a8e92a4e59ec5f74662f2db519ae5a9 100644
--- a/public/web/WebViewClient.h
+++ b/public/web/WebViewClient.h
@@ -45,6 +45,7 @@
#include "WebTextAffinity.h"
#include "WebTextDirection.h"
#include "WebWidgetClient.h"
+#include <v8.h>
abarth-chromium 2013/07/19 03:12:17 Hum... This is suspicious. We probably don't wan
namespace WebKit {
@@ -126,9 +127,16 @@ public:
// Misc ----------------------------------------------------------------
- // A new message was added to the console.
+ // Whether or not we should report a detailed message for the given source.
+ virtual bool shouldReportDetailedMessageForContext(v8::Handle<v8::Context>) { return false; }
+ virtual bool shouldReportDetailedMessageForURL(const WebString& source) { return false; }
+
+ // A new message was added to the console. If a detailed message should be
+ // reported, a stringified JSON object is included; otherwise, |details| is
+ // empty.
virtual void didAddMessageToConsole(
- const WebConsoleMessage&, const WebString& sourceName, unsigned sourceLine) { }
+ const WebConsoleMessage&, const WebString& sourceName,
+ unsigned sourceLine, const WebString& details) { }
// Called when script in the page calls window.print(). If frame is
// non-null, then it selects a particular frame, including its
« Source/core/page/Chrome.cpp ('K') | « public/testing/WebTestProxy.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698