Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 1880343003: Added git-hash-metrics builder and recipe (Closed)

Created:
4 years, 8 months ago by pgervais
Modified:
4 years, 8 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Added git-hash-metrics builder and recipe BUG=602803 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300094

Patch Set 1 #

Total comments: 1

Patch Set 2 : Ahem. Fixed metric type. #

Patch Set 3 : Ahem. Updated expectations #

Patch Set 4 : Added missing import and rebase #

Patch Set 5 : Fixed presubmit errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -0 lines) Patch
M masters/master.chromium.infra.cron/master.cfg View 1 2 3 4 4 chunks +25 lines, -0 lines 0 comments Download
M masters/master.chromium.infra.cron/slaves.cfg View 1 chunk +5 lines, -0 lines 0 comments Download
A scripts/slave/recipes/infra/git_hash_metric.py View 1 2 3 4 1 chunk +36 lines, -0 lines 0 comments Download
A scripts/slave/recipes/infra/git_hash_metric.expected/infra.json View 1 2 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (11 generated)
pgervais
Waiting for a better solution... ptal.
4 years, 8 months ago (2016-04-13 00:19:33 UTC) #2
pgervais
On 2016/04/13 00:19:33, pgervais wrote: > Waiting for a better solution... > ptal. ping. Or ...
4 years, 8 months ago (2016-04-18 17:06:37 UTC) #3
Sergey Berezin
On 2016/04/18 17:06:37, pgervais wrote: > On 2016/04/13 00:19:33, pgervais wrote: > > Waiting for ...
4 years, 8 months ago (2016-04-18 17:14:22 UTC) #4
Sergey Berezin
Let's proceed with a buildbot cron for now, I don't have any better idea for ...
4 years, 8 months ago (2016-04-18 17:22:45 UTC) #5
pgervais
Fix filed, ptal.
4 years, 8 months ago (2016-04-19 00:43:24 UTC) #6
Sergey Berezin (google)
LGTM. BTW, why didn't expectation change with --string?
4 years, 8 months ago (2016-04-21 17:18:14 UTC) #8
pgervais
On 2016/04/21 17:18:14, Sergey Berezin (google) wrote: > LGTM. BTW, why didn't expectation change with ...
4 years, 8 months ago (2016-04-21 17:27:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880343003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880343003/40001
4 years, 8 months ago (2016-04-21 17:29:40 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/4197)
4 years, 8 months ago (2016-04-21 17:37:25 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880343003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880343003/60001
4 years, 8 months ago (2016-04-21 17:42:45 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/4199)
4 years, 8 months ago (2016-04-21 17:50:35 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880343003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880343003/80001
4 years, 8 months ago (2016-04-21 21:50:31 UTC) #22
commit-bot: I haz the power
Committed patchset #5 (id:80001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=300094
4 years, 8 months ago (2016-04-21 21:54:31 UTC) #24
Matt Giuca
4 years, 8 months ago (2016-04-26 00:31:28 UTC) #25
Message was sent while issue was closed.
On 2016/04/21 21:54:31, commit-bot: I haz the power wrote:
> Committed patchset #5 (id:80001) as
> http://src.chromium.org/viewvc/chrome?view=rev&revision=300094

This doesn't seem to be hooked up correctly:
https://bugs.chromium.org/p/chromium/issues/detail?id=606599

Powered by Google App Engine
This is Rietveld 408576698