Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: net/socket/client_socket_handle.h

Issue 18796003: When an idle socket is added back to a socket pool, check for stalled jobs in lower pools (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Update comments Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_proxy_client_socket_pool.cc ('k') | net/socket/client_socket_handle.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/client_socket_handle.h
===================================================================
--- net/socket/client_socket_handle.h (revision 219027)
+++ net/socket/client_socket_handle.h (working copy)
@@ -94,9 +94,15 @@
bool IsPoolStalled() const;
- void AddLayeredPool(LayeredPool* layered_pool);
+ // Adds a higher layered pool on top of the socket pool that |socket_| belongs
+ // to. At most one higher layered pool can be added to a
+ // ClientSocketHandle at a time. On destruction or reset, automatically
+ // removes the higher pool if RemoveHigherLayeredPool has not been called.
+ void AddHigherLayeredPool(HigherLayeredPool* higher_pool);
- void RemoveLayeredPool(LayeredPool* layered_pool);
+ // Removes a higher layered pool from the socket pool that |socket_| belongs
+ // to. |higher_pool| must have been added by the above function.
+ void RemoveHigherLayeredPool(HigherLayeredPool* higher_pool);
// Returns true when Init() has completed successfully.
bool is_initialized() const { return is_initialized_; }
@@ -184,7 +190,7 @@
bool is_initialized_;
ClientSocketPool* pool_;
- LayeredPool* layered_pool_;
+ HigherLayeredPool* higher_pool_;
scoped_ptr<StreamSocket> socket_;
std::string group_name_;
bool is_reused_;
« no previous file with comments | « net/http/http_proxy_client_socket_pool.cc ('k') | net/socket/client_socket_handle.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698