Source/bindings/v8/custom/V8HTMLImageElementConstructor.cpp - Issue 18778002: Inherit EventTarget interface instead of duplicating its code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8HTMLImageElementConstructor.cpp

Issue 18778002: Inherit EventTarget interface instead of duplicating its code (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase on master Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/v8/custom/V8HTMLImageElementConstructor.cpp

diff --git a/Source/bindings/v8/custom/V8HTMLImageElementConstructor.cpp b/Source/bindings/v8/custom/V8HTMLImageElementConstructor.cpp

index e50175341001dfdbefa09d426ed98c94a117d410..4704deabacfc34fc70d162df4ffc5a62f0c542d4 100644

--- a/Source/bindings/v8/custom/V8HTMLImageElementConstructor.cpp

+++ b/Source/bindings/v8/custom/V8HTMLImageElementConstructor.cpp

@@ -82,7 +82,7 @@ static void v8HTMLImageElementConstructorMethodCustom(const v8::FunctionCallback

RefPtr<HTMLImageElement> image = HTMLImageElement::createForJSConstructor(document, optionalWidth, optionalHeight);

v8::Handle<v8::Object> wrapper = args.Holder();

- V8DOMWrapper::associateObjectWithWrapper(image.release(), &V8HTMLImageElementConstructor::info, wrapper, args.GetIsolate(), WrapperConfiguration::Dependent);

+ V8DOMWrapper::associateObjectWithWrapper<V8HTMLImageElement>(image.release(), &V8HTMLImageElementConstructor::info, wrapper, args.GetIsolate(), WrapperConfiguration::Dependent);

v8SetReturnValue(args, wrapper);

}

« no previous file with comments | « Source/bindings/v8/custom/V8FormDataCustom.cpp ('k') | Source/bindings/v8/custom/V8MessageChannelCustom.cpp » ('j') | no next file with comments »