Source/bindings/v8/custom/V8MessageChannelCustom.cpp - Issue 18778002: Inherit EventTarget interface instead of duplicating its code

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/bindings/v8/custom/V8MessageChannelCustom.cpp

Issue 18778002: Inherit EventTarget interface instead of duplicating its code (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase on master Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2009 Google Inc. All rights reserved.	2 * Copyright (C) 2009 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 40 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
51 RefPtr<MessageChannel> obj = MessageChannel::create(context);	51 RefPtr<MessageChannel> obj = MessageChannel::create(context);

52	52

53 v8::Local<v8::Object> wrapper = args.Holder();	53 v8::Local<v8::Object> wrapper = args.Holder();

54	54

55 // Create references from the MessageChannel wrapper to the two	55 // Create references from the MessageChannel wrapper to the two

56 // MessagePort wrappers to make sure that the MessagePort wrappers	56 // MessagePort wrappers to make sure that the MessagePort wrappers

57 // stay alive as long as the MessageChannel wrapper is around.	57 // stay alive as long as the MessageChannel wrapper is around.

58 V8HiddenPropertyName::setNamedHiddenReference(wrapper, "port1", toV8(obj->po rt1(), args.Holder(), args.GetIsolate()));	58 V8HiddenPropertyName::setNamedHiddenReference(wrapper, "port1", toV8(obj->po rt1(), args.Holder(), args.GetIsolate()));

59 V8HiddenPropertyName::setNamedHiddenReference(wrapper, "port2", toV8(obj->po rt2(), args.Holder(), args.GetIsolate()));	59 V8HiddenPropertyName::setNamedHiddenReference(wrapper, "port2", toV8(obj->po rt2(), args.Holder(), args.GetIsolate()));

60	60

61 V8DOMWrapper::associateObjectWithWrapper(obj.release(), &info, wrapper, args .GetIsolate(), WrapperConfiguration::Dependent);	61 V8DOMWrapper::associateObjectWithWrapper<V8MessageChannel>(obj.release(), &i nfo, wrapper, args.GetIsolate(), WrapperConfiguration::Dependent);

62 args.GetReturnValue().Set(wrapper);	62 args.GetReturnValue().Set(wrapper);

63 }	63 }

64	64

65 } // namespace WebCore	65 } // namespace WebCore

OLD	NEW