[Telemetry] Cut down on the amount of log spam on the android perf bots.

[Telemetry] Cut down on the amount of log spam on the android perf bots.

The perf bots run with -v (INFO level debugging). I'm moving the noisiest
output to DEBUG level. This will make the android log output more parsable
so that the real failures are easier to spot.

Also, this cuts down on several commands running between each page.

BUG=None
TEST=smoothness and page_cycler on android

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211673

[bulach, 2013-07-15 09:03:56]

lgtm, thanks! just a nit below:

https://codereview.chromium.org/18764005/diff/1/tools/telemetry/telemetry/pag...
File tools/telemetry/telemetry/page/page_runner.py (right):

https://codereview.chromium.org/18764005/diff/1/tools/telemetry/telemetry/pag...
tools/telemetry/telemetry/page/page_runner.py:417: if was_throttled and
platform.IsThermallyThrottled():
nit: this would change the semantics, as the loop above may terminate after 3
tries whilst the device is still throttled..

[tonyg, 2013-07-15 15:50:26]

https://codereview.chromium.org/18764005/diff/1/tools/telemetry/telemetry/pag...
File tools/telemetry/telemetry/page/page_runner.py (right):

https://codereview.chromium.org/18764005/diff/1/tools/telemetry/telemetry/pag...
tools/telemetry/telemetry/page/page_runner.py:417: if was_throttled and
platform.IsThermallyThrottled():
On 2013/07/15 09:03:56, bulach wrote:
> nit: this would change the semantics, as the loop above may terminate after 3
> tries whilst the device is still throttled..

Unless I'm missing something, I don't think so.

The idea here is to avoid calling IsThermallyThrottled() twice in a row in the
case that the first one does not return True. So...

If the first IsThermallyThrottled() returns False, we never enter the while-loop
and was_throttled returns False so we avoid the redundant call.

If the first IsThermallyThrottled() returns True, then we enter the while-loop,
setting was_throttled to True so we will still call this final
IsThermallyThrottled() upon finishing this method.

Make sense? Is there a cleaner way to structure this?

[bulach, 2013-07-15 15:59:44]

still lgtm, clarification below:

https://codereview.chromium.org/18764005/diff/1/tools/telemetry/telemetry/pag...
File tools/telemetry/telemetry/page/page_runner.py (right):

https://codereview.chromium.org/18764005/diff/1/tools/telemetry/telemetry/pag...
tools/telemetry/telemetry/page/page_runner.py:417: if was_throttled and
platform.IsThermallyThrottled():
On 2013/07/15 15:50:26, tonyg wrote:
> On 2013/07/15 09:03:56, bulach wrote:
> > nit: this would change the semantics, as the loop above may terminate after
3
> > tries whilst the device is still throttled..
> 
> Unless I'm missing something, I don't think so.
> 
> The idea here is to avoid calling IsThermallyThrottled() twice in a row in the
> case that the first one does not return True. So...
> 
> If the first IsThermallyThrottled() returns False, we never enter the
while-loop
> and was_throttled returns False so we avoid the redundant call.
> 
> If the first IsThermallyThrottled() returns True, then we enter the
while-loop,
> setting was_throttled to True so we will still call this final
> IsThermallyThrottled() upon finishing this method.
> 
> Make sense? Is there a cleaner way to structure this?

of course, you're right: sorry I got confused...

not sure if this would be any clearer, but perhaps rather than adding another
local:

if thermal_throttling_retry > 0 and platform.IsThermallyThrottled():

[tonyg, 2013-07-15 16:17:06]

https://codereview.chromium.org/18764005/diff/1/tools/telemetry/telemetry/pag...
File tools/telemetry/telemetry/page/page_runner.py (right):

https://codereview.chromium.org/18764005/diff/1/tools/telemetry/telemetry/pag...
tools/telemetry/telemetry/page/page_runner.py:417: if was_throttled and
platform.IsThermallyThrottled():
On 2013/07/15 15:59:44, bulach wrote:
> On 2013/07/15 15:50:26, tonyg wrote:
> > On 2013/07/15 09:03:56, bulach wrote:
> > > nit: this would change the semantics, as the loop above may terminate
after
> 3
> > > tries whilst the device is still throttled..
> > 
> > Unless I'm missing something, I don't think so.
> > 
> > The idea here is to avoid calling IsThermallyThrottled() twice in a row in
the
> > case that the first one does not return True. So...
> > 
> > If the first IsThermallyThrottled() returns False, we never enter the
> while-loop
> > and was_throttled returns False so we avoid the redundant call.
> > 
> > If the first IsThermallyThrottled() returns True, then we enter the
> while-loop,
> > setting was_throttled to True so we will still call this final
> > IsThermallyThrottled() upon finishing this method.
> > 
> > Make sense? Is there a cleaner way to structure this?
> 
> of course, you're right: sorry I got confused...
> 
> not sure if this would be any clearer, but perhaps rather than adding another
> local:
> 
> if thermal_throttling_retry > 0 and platform.IsThermallyThrottled():

Good call, I didn't notice that before. Done.

[bulach, 2013-07-15 16:18:17]

lgtm, thanks!!

[commit-bot: I haz the power, 2013-07-15 16:22:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tonyg@chromium.org/18764005/5002

[commit-bot: I haz the power, 2013-07-15 20:17:43]

Change committed as 211673