Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 18764003: Hovered/active/focused will never share style with siblings/cousins. (Closed)

Created:
7 years, 5 months ago by rune
Modified:
7 years, 5 months ago
Reviewers:
eae
CC:
blink-reviews, apavlov+blink_chromium.org, dglazkov+blink, eae+blinkwatch, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Hovered/active/focused will never share style with siblings/cousins. For any given hovered/active node at a given time, other hovered/active nodes are either ancestors or descendants of that node. Since style sharing is looking at siblings and cousins, hovered/active nodes will never share style. Similarly, there's always a single focused element in a document, hence it will never share style with another node. BUG=255189 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153773

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -0 lines) Patch
A PerformanceTests/CSS/FocusUpdate.html View 1 chunk +39 lines, -0 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rune
New attempt since the first CL[1] was reverted because it used a JS API for ...
7 years, 5 months ago (2013-07-05 12:32:34 UTC) #1
rune
On 2013/07/05 12:32:34, rune wrote: > New attempt since the first CL[1] was reverted because ...
7 years, 5 months ago (2013-07-05 12:34:17 UTC) #2
eae
LGTM
7 years, 5 months ago (2013-07-08 15:32:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/18764003/1
7 years, 5 months ago (2013-07-09 10:41:16 UTC) #4
commit-bot: I haz the power
7 years, 5 months ago (2013-07-09 10:44:30 UTC) #5
Message was sent while issue was closed.
Change committed as 153773

Powered by Google App Engine
This is Rietveld 408576698