Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: content/renderer/render_widget.h

Issue 18750003: Require ACK for editor-related changes not originating from browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed compile warning on windows Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_widget.h
diff --git a/content/renderer/render_widget.h b/content/renderer/render_widget.h
index e5ab98921e34ca0945ec5f34f3900c3bdc96b64c..1c38ac50c958cd895602ef3d5ddf9e3cad3575f3 100644
--- a/content/renderer/render_widget.h
+++ b/content/renderer/render_widget.h
@@ -331,7 +331,22 @@ class CONTENT_EXPORT RenderWidget
#if defined(OS_ANDROID)
void OnImeBatchStateChanged(bool is_begin);
void OnShowImeIfNeeded();
+ // Returns whether ordered IME processing has been enabled.
Seigo Nonaka 2013/07/10 02:22:17 nit: newline between comment and next function?
nyquist 2013/07/12 05:55:24 Done.
+ bool has_ordered_ime_processing() { return has_ordered_ime_processing_; }
+ // Whenever an IME event that needs an acknowledgement is sent to the browser,
+ // the number of outstanding IME events that needs acknowledgement should be
+ // incremented.
+ void IncrementOutstandingImeEventAcks();
+ // If there are outstanding IME events that needs to be acknowledged, all
+ // new IME events should be discarded. This only returns true if ordered IME
+ // processing is enabled.
+ bool HasOutstandingImeEventAcks();
+ // Called by the browser process for every required IME acknowledgement.
+ void OnImeEventAck();
#endif
+ // Returns whether we currently should handle an IME event.
+ bool ShouldHandleImeEvent();
+
void OnSnapshot(const gfx::Rect& src_subrect);
void OnSetBrowserRenderingStats(const BrowserRenderingStats& stats);
@@ -715,6 +730,16 @@ class CONTENT_EXPORT RenderWidget
// frame.
ui::LatencyInfo latency_info_;
+#if defined(OS_ANDROID)
+ // Specifies if the ordered IME processing has been enabled.
+ bool has_ordered_ime_processing_;
+
+ // A counter for number of outstanding messages from the renderer to the
+ // browser regarding IME-type events that have not been acknowledged by the
+ // browser.
+ int outstanding_ime_acks_;
+#endif
+
base::WeakPtrFactory<RenderWidget> weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(RenderWidget);

Powered by Google App Engine
This is Rietveld 408576698