Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: build/common.gypi

Issue 187393005: Make it possible to read CLD data from a file (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Guard static initialization with #ifdef Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 4f64932fb0383b83236a028f973a1fd72616cd65..be32e7f4a59c47a7740f5d39702ddb8e7c3d8817 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -425,13 +425,20 @@
'cld_version%': 2,
# For CLD2, the size of the tables that should be included in the build
- # Only evaluated if cld_version == 2.
+ # Only evaluated if cld_version == 2 or if building the CLD2 dynamic data
+ # tool explicitly.
# See third_party/cld_2/cld_2.gyp for more information.
# 0: Small tables, lower accuracy
# 1: Medium tables, medium accuracy
# 2: Large tables, high accuracy
'cld2_table_size%': 2,
+ # Set the way CLD is compiled. Only evaluated if cld_version == 2.
+ # 0: static, language scoring tables compiled into the binary
+ # 1: dynamic, language scoring tables live in a data file that must
+ # be loaded at runtime.
+ 'cld2_dynamic%': 0,
+
# Enable spell checker.
'enable_spellcheck%': 1,
@@ -629,6 +636,7 @@
'enable_extensions%': 0,
'enable_google_now%': 0,
'cld_version%': 1,
+ 'cld2_dynamic%': 0,
'enable_spellcheck%': 0,
'enable_themes%': 0,
'remoting%': 0,
@@ -679,6 +687,7 @@
'enable_extensions%': 0,
'enable_google_now%': 0,
'cld_version%': 1,
+ 'cld2_dynamic%': 0,
'enable_printing%': 0,
'enable_session_service%': 0,
'enable_themes%': 0,
@@ -995,6 +1004,7 @@
'enable_google_now%': '<(enable_google_now)',
'cld_version%': '<(cld_version)',
'cld2_table_size%': '<(cld2_table_size)',
+ 'cld2_dynamic%': '<(cld2_dynamic)',
'enable_captive_portal_detection%': '<(enable_captive_portal_detection)',
'disable_ftp_support%': '<(disable_ftp_support)',
'enable_task_manager%': '<(enable_task_manager)',
@@ -2502,6 +2512,9 @@
['cld_version!=0', {
'defines': ['CLD_VERSION=<(cld_version)'],
}],
+ ['cld2_dynamic!=0', {
+ 'defines': ['CLD2_DYNAMIC_MODE=1'],
+ }],
['enable_printing==1', {
'defines': ['ENABLE_FULL_PRINTING=1', 'ENABLE_PRINTING=1'],
}],
« no previous file with comments | « no previous file | chrome/browser/translate/translate_tab_helper.h » ('j') | chrome/renderer/translate/translate_helper.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698