media/blink/webmediaplayer_impl.h - Issue 1873513003: Add video-rendering to mojo media pipeline.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/blink/webmediaplayer_impl.h

Issue 1873513003: Add video-rendering to mojo media pipeline. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: minor cleanup Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/blink/webmediaplayer_impl.h

diff --git a/media/blink/webmediaplayer_impl.h b/media/blink/webmediaplayer_impl.h

index 25a1e72ba7e946227ca38b17fbe11d5639e64517..152d6682c7f6e028967105d974738a5d5901165c 100644

--- a/media/blink/webmediaplayer_impl.h

+++ b/media/blink/webmediaplayer_impl.h

@@ -268,7 +268,7 @@ class MEDIA_BLINK_EXPORT WebMediaPlayerImpl

// Callbacks from |pipeline_| that are forwarded to |client_|.

void OnDurationChanged();

- void OnNaturalSizeChanged(gfx::Size size);

+ void OnNaturalSizeChanged(const gfx::Size& size);

xhwang 2016/04/12 19:40:37 Interesting. I think your change makes sense: htt

void OnOpacityChanged(bool opaque);

// Called by VideoRendererImpl on its internal thread with the new frame to be