Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: src/messages.h

Issue 1872373002: Move MessageLocations constructor out of header (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@show-wasm-frames-4
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/messages.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/messages.h
diff --git a/src/messages.h b/src/messages.h
index da9637b9410c18ebfe6a8bd5cec5d8303e04d94a..9edaceee865e23b8f5931987155afb9a02a01c0d 100644
--- a/src/messages.h
+++ b/src/messages.h
@@ -24,13 +24,10 @@ class SourceInfo;
class MessageLocation {
public:
+ MessageLocation(Handle<Script> script, int start_pos, int end_pos);
MessageLocation(Handle<Script> script, int start_pos, int end_pos,
- Handle<JSFunction> function = Handle<JSFunction>())
- : script_(script),
- start_pos_(start_pos),
- end_pos_(end_pos),
- function_(function) {}
- MessageLocation() : start_pos_(-1), end_pos_(-1) { }
+ Handle<JSFunction> function);
+ MessageLocation();
Handle<Script> script() const { return script_; }
int start_pos() const { return start_pos_; }
« no previous file with comments | « no previous file | src/messages.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698