Minor cleanup of some recipe framework code.

scripts/slave/recipe_modules/step_history/api.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import collections
 
 from slave import recipe_api
 
 class StepHistoryApi(recipe_api.RecipeApi, collections.Mapping):
   """
   Provide an OrderedDict-like view into the steps that have run, and what
   data they've returned.
 
   Each entry in step_history is an object() which has the attributes:
     * retcode
     * <module_name>.<module_specific_data>
   """
 
   def __init__(self, step_history, **kwargs):
     super(StepHistoryApi, self).__init__(**kwargs)
+    # step_history is instantiated in annontated_run.py. Recipe engine is

[Vadim Sh., 2014/03/05 06:09:30]

That was non obvious dependency for me. Also added and assert as a type hint.
OrderedDict is crucial since we rely on order in last_step.

[iannucci, 2014/03/05 20:43:37]

Oh, yeah, this is the other thing that we pass via kwargs in load_module. Can
you make it a kwarg though, since it's meant to be used by name?

Can't wait to get rid of this module...

[Vadim Sh., 2014/03/05 21:40:38]

What do you mean? kwargs.get('step_history')? Than same should be done in
'properties' module. Not sure it improves readability.

+    # responsible for updating it.
+    assert isinstance(step_history, collections.OrderedDict)
     self._step_history = step_history
 
   def __getitem__(self, key):
     # NOTE: Ideally, we could constify the values here. However, APIs are
     # allowed to add any arbitrary data to step history items, so this would
     # be essentially impossible without significant additional code.
     return self._step_history[key]
 
   def __iter__(self):  # pragma: no cover
     return iter(self._step_history)
 
   def __len__(self):  # pragma: no cover
     return len(self._step_history)
 
   @property
   def failed(self):
     """Return status of the build so far, as a bool."""
     return self._step_history.failed
 
   def last_step(self):
     """Return the last StepData object, or None if no steps have run."""
     key = next(reversed(self._step_history), None)
     return self[key] if key else None