Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1871943003: Add Info Testable interface, implement for memory. (Closed)

Created:
4 years, 8 months ago by dnj
Modified:
4 years, 8 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/luci/gae@master
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Add Info Testable interface, implement for memory. This adds a Testable interface to the Info service which allows it to install Info parameters in Contexts. Add support for setting version ID and request ID to impl/memory Info service. BUG= Committed: https://github.com/luci/gae/commit/15da1e8958be9f9f899296d2dbe882195a8b2090

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fall through in filter. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -13 lines) Patch
M filter/count/gi.go View 1 1 chunk +4 lines, -0 lines 0 comments Download
M impl/dummy/dummy.go View 1 chunk +1 line, -0 lines 0 comments Download
M impl/memory/context.go View 1 chunk +4 lines, -2 lines 0 comments Download
M impl/memory/info.go View 3 chunks +55 lines, -11 lines 0 comments Download
M impl/memory/info_test.go View 1 chunk +19 lines, -0 lines 0 comments Download
M impl/prod/info.go View 1 chunk +4 lines, -0 lines 0 comments Download
M service/info/interface.go View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dnj
PTAL
4 years, 8 months ago (2016-04-08 15:58:09 UTC) #2
iannucci
lgtm https://chromiumcodereview.appspot.com/1871943003/diff/1/filter/count/gi.go File filter/count/gi.go (right): https://chromiumcodereview.appspot.com/1871943003/diff/1/filter/count/gi.go#newcode148 filter/count/gi.go:148: return nil this should call through to g.gi.Testable(), ...
4 years, 8 months ago (2016-04-14 01:12:38 UTC) #3
dnj
https://chromiumcodereview.appspot.com/1871943003/diff/1/filter/count/gi.go File filter/count/gi.go (right): https://chromiumcodereview.appspot.com/1871943003/diff/1/filter/count/gi.go#newcode148 filter/count/gi.go:148: return nil On 2016/04/14 01:12:38, iannucci wrote: > this ...
4 years, 8 months ago (2016-04-14 01:15:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1871943003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1871943003/20001
4 years, 8 months ago (2016-04-14 01:15:29 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 01:20:48 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/gae/commit/15da1e8958be9f9f899296d2dbe882195a8b2090

Powered by Google App Engine
This is Rietveld 408576698