Issue 18718003: Add both node paths to both Polymer steps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18718003: Add both node paths to both Polymer steps. (Closed)

Created:
7 years, 5 months ago by agable

Modified:
7 years, 5 months ago

Reviewers:
iannucci

CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org, xusydoc+watch_chromium.org, kjellander+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/build

Visibility:
Public.

More Reviews

Description

Add both node paths to both Polymer steps. Perhaps unsurprisingly, grunt calls node.exe, so it needs both paths to be present in %PATH%. This CL is a response to the comment in crrev.com/18958002. I'll be fixing run_recipe.py to do path-purging like buildbot does to catch things like this next. TBR=iannucci@chromium.org BUG=229168 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=210660

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -7 lines)			Patch
	M	scripts/slave/recipes/polymer.py	View		1 chunk	+6 lines, -5 lines	0 comments	Download
	M	scripts/slave/recipes/polymer.expected/polymer-win.json	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agable@chromium.org/18718003/1

7 years, 5 months ago (2013-07-09 23:31:40 UTC) #2

Message was sent while issue was closed.

Change committed as 210660

Expand Messages | Collapse Messages