Remove the Data Reduction Proxy TLS experiment code

Remove the Data Reduction Proxy TLS experiment code

Chrome used to support an experiment to tunnel TLS traffic
through the Data Reduction Proxy using HTTP CONNECT. The
experiment is over so this code is no longer needed.

BUG=593068
Committed: https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267
Cr-Commit-Position: refs/heads/master@{#387162}

[megjablon, 2016-04-08 20:43:16]

Patchset #1 (id:1) has been deleted

[megjablon, 2016-04-08 20:58:12]

Description was changed from

==========
Remove the Data Reduction Proxy TLS experiment code

BUG=593068
==========

to

==========
Remove the Data Reduction Proxy TLS experiment code

Chrome used to support an experiment to tunnel TLS traffic
through the Data Reduction Proxy using HTTP CONNECT. The
experiment is over so this code is no longer needed.

BUG=593068
==========

[megjablon, 2016-04-12 00:33:19]

megjablon@chromium.org changed reviewers:
+ tbansal@chromium.org

[megjablon, 2016-04-12 00:33:38]

PTAL thanks!

[tbansal1, 2016-04-12 05:16:31]

This patch looks good. It might also be easier to just grep for case-insensitive
occurrences of terms like "ssl", "https", "proxies_for_https", "connect" in
d_r_p/, and make sure that all occurrences are either required, or removed.

https://codereview.chromium.org/1871783002/diff/40001/chrome/browser/net/spdy...
File chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.cc
(left):

https://codereview.chromium.org/1871783002/diff/40001/chrome/browser/net/spdy...
chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.cc:195:
DataReductionProxySettingsAndroid::GetHttpsProxyList(
Remove function from .h file.

https://codereview.chromium.org/1871783002/diff/40001/components/data_reducti...
File components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h
(right):

https://codereview.chromium.org/1871783002/diff/40001/components/data_reducti...
components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h:121:
// ssl; these are not mutually exclusive. |proxy_info| can be NULL if the
"ssl": Remove/Reword this comment?

https://codereview.chromium.org/1871783002/diff/40001/components/data_reducti...
File components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
(right):

https://codereview.chromium.org/1871783002/diff/40001/components/data_reducti...
components/data_reduction_proxy/core/common/data_reduction_proxy_params.h:147:
// |proxies_for_https| contain the configured data reduction proxy servers.
Remove/Reword this comment because it contains |proxies_for_https|

[megjablon, 2016-04-12 21:02:37]

A grep for "proxies_for_https" was useful. I left one case which checks in the
configuration unit test which checks that the ProxyConfig's ProxyRules has no
https proxies. There are too many occurrences of "https" in the DRP component
for a grep of that to be useful. "ssl" and "connect" are still used in many
other locations, but I looked through them and all of the remaining are used in
different contexts than the TLS experiment.

https://chromiumcodereview.appspot.com/1871783002/diff/40001/chrome/browser/n...
File chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.cc
(left):

https://chromiumcodereview.appspot.com/1871783002/diff/40001/chrome/browser/n...
chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.cc:195:
DataReductionProxySettingsAndroid::GetHttpsProxyList(
On 2016/04/12 05:16:31, tbansal1 wrote:
> Remove function from .h file.

Done.

https://chromiumcodereview.appspot.com/1871783002/diff/40001/components/data_...
File components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h
(right):

https://chromiumcodereview.appspot.com/1871783002/diff/40001/components/data_...
components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h:121:
// ssl; these are not mutually exclusive. |proxy_info| can be NULL if the
On 2016/04/12 05:16:31, tbansal1 wrote:
> "ssl": Remove/Reword this comment?

Done.

https://chromiumcodereview.appspot.com/1871783002/diff/40001/components/data_...
File components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
(right):

https://chromiumcodereview.appspot.com/1871783002/diff/40001/components/data_...
components/data_reduction_proxy/core/common/data_reduction_proxy_params.h:147:
// |proxies_for_https| contain the configured data reduction proxy servers.
On 2016/04/12 05:16:31, tbansal1 wrote:
> Remove/Reword this comment because it contains |proxies_for_https|

Done.

[tbansal1, 2016-04-12 21:43:15]

lgtm % two minor nits. Thanks for cleaning this up!!

https://chromiumcodereview.appspot.com/1871783002/diff/60001/components/data_...
File
components/data_reduction_proxy/core/common/data_reduction_proxy_config_values.h
(right):

https://chromiumcodereview.appspot.com/1871783002/diff/60001/components/data_...
components/data_reduction_proxy/core/common/data_reduction_proxy_config_values.h:13:
class HostPortPair;
nit: This forward declaration is not needed anymore.

https://chromiumcodereview.appspot.com/1871783002/diff/60001/components/data_...
File components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
(right):

https://chromiumcodereview.appspot.com/1871783002/diff/60001/components/data_...
components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc:19:
#include "net/base/host_port_pair.h"
This include (host_port_pair.h) is not needed anymore.

[megjablon, 2016-04-12 21:58:18]

Thanks for catching those!

https://chromiumcodereview.appspot.com/1871783002/diff/60001/components/data_...
File
components/data_reduction_proxy/core/common/data_reduction_proxy_config_values.h
(right):

https://chromiumcodereview.appspot.com/1871783002/diff/60001/components/data_...
components/data_reduction_proxy/core/common/data_reduction_proxy_config_values.h:13:
class HostPortPair;
On 2016/04/12 21:43:15, tbansal1 wrote:
> nit: This forward declaration is not needed anymore.

Done.

https://chromiumcodereview.appspot.com/1871783002/diff/60001/components/data_...
File components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
(right):

https://chromiumcodereview.appspot.com/1871783002/diff/60001/components/data_...
components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc:19:
#include "net/base/host_port_pair.h"
On 2016/04/12 21:43:15, tbansal1 wrote:
> This include (host_port_pair.h) is not needed anymore.

Done.

[megjablon, 2016-04-12 21:58:41]

megjablon@chromium.org changed reviewers:
+ newt@chromium.org

[megjablon, 2016-04-12 21:58:41]

newt: Please review changes in DataReductionProxySettings.java

[megjablon, 2016-04-12 21:59:06]

megjablon@chromium.org changed reviewers:
- newt@chromium.org

[megjablon, 2016-04-12 22:00:25]

megjablon@chromium.org changed reviewers:
+ yfriedman@chromium.org

[megjablon, 2016-04-12 22:00:25]

Moving to yfriedman

yfriedman: Please review changes in DataReductionProxySettings.java

[Yaron, 2016-04-12 23:02:42]

lgtm

[megjablon, 2016-04-12 23:04:07]

The CQ bit was checked by megjablon@chromium.org

[megjablon, 2016-04-12 23:04:07]

The patchset sent to the CQ was uploaded after l-g-t-m from tbansal@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1871783002/#ps80001
(title: "remove includes")

[commit-bot: I haz the power, 2016-04-12 23:04:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1871783002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1871783002/80001

[commit-bot: I haz the power, 2016-04-13 00:00:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 00:00:28]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[megjablon, 2016-04-13 23:18:09]

The CQ bit was checked by megjablon@chromium.org

[megjablon, 2016-04-13 23:18:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
yfriedman@chromium.org, tbansal@chromium.org
Link to the patchset:
https://chromiumcodereview.appspot.com/1871783002/#ps100001 (title: "rebase")

[commit-bot: I haz the power, 2016-04-13 23:18:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1871783002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1871783002/100001

[commit-bot: I haz the power, 2016-04-14 00:08:40]

Description was changed from

==========
Remove the Data Reduction Proxy TLS experiment code

Chrome used to support an experiment to tunnel TLS traffic
through the Data Reduction Proxy using HTTP CONNECT. The
experiment is over so this code is no longer needed.

BUG=593068
==========

to

==========
Remove the Data Reduction Proxy TLS experiment code

Chrome used to support an experiment to tunnel TLS traffic
through the Data Reduction Proxy using HTTP CONNECT. The
experiment is over so this code is no longer needed.

BUG=593068
==========

[commit-bot: I haz the power, 2016-04-14 00:08:41]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-04-14 00:10:00]

Description was changed from

==========
Remove the Data Reduction Proxy TLS experiment code

Chrome used to support an experiment to tunnel TLS traffic
through the Data Reduction Proxy using HTTP CONNECT. The
experiment is over so this code is no longer needed.

BUG=593068
==========

to

==========
Remove the Data Reduction Proxy TLS experiment code

Chrome used to support an experiment to tunnel TLS traffic
through the Data Reduction Proxy using HTTP CONNECT. The
experiment is over so this code is no longer needed.

BUG=593068

Committed: https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267
Cr-Commit-Position: refs/heads/master@{#387162}
==========

[commit-bot: I haz the power, 2016-04-14 00:10:01]

Patchset 5 (id:??) landed as
https://crrev.com/842e143a1a344bc4865d7ae85a300d0dba45a267
Cr-Commit-Position: refs/heads/master@{#387162}