Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 18710003: Android / dmprof: explodes policies for shared areas. (Closed)

Created:
7 years, 5 months ago by bulach
Modified:
7 years, 3 months ago
CC:
chromium-reviews, dmikurube+memory_chromium.org
Visibility:
Public.

Description

Android / dmprof: explodes policies for shared areas. After crrev.com/208163, dmprof can segregate areas that are shared with chrome processes and others. Use this feature in the android policies. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221278

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Remove pvrsrvkm #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -12 lines) Patch
M tools/deep_memory_profiler/policy.android.browser.json View 1 3 chunks +23 lines, -6 lines 0 comments Download
M tools/deep_memory_profiler/policy.android.renderer.json View 1 3 chunks +23 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
bulach
ptal
7 years, 5 months ago (2013-07-04 15:58:47 UTC) #1
Sami
https://codereview.chromium.org/18710003/diff/2001/tools/deep_memory_profiler/policy.android.browser.json File tools/deep_memory_profiler/policy.android.browser.json (right): https://codereview.chromium.org/18710003/diff/2001/tools/deep_memory_profiler/policy.android.browser.json#newcode127 tools/deep_memory_profiler/policy.android.browser.json:127: "name": "unhooked-pvrsrvkm-private", Keeping these under a single category like ...
7 years, 5 months ago (2013-07-04 17:13:12 UTC) #2
Dai Mikurube (NOT FULLTIME)
LGTM!
7 years, 5 months ago (2013-07-05 03:43:46 UTC) #3
bulach
thanks both! :) sami, I removed the pvrsrvkm, ptal
7 years, 5 months ago (2013-07-05 08:27:39 UTC) #4
bulach
sorry, this went off my radar... sami, does it look good to you?
7 years, 4 months ago (2013-08-22 08:53:41 UTC) #5
Sami
lgmt!
7 years, 3 months ago (2013-09-04 18:55:04 UTC) #6
Sami
erm, lgtm
7 years, 3 months ago (2013-09-04 18:55:17 UTC) #7
bulach
thanks! :) CQing.
7 years, 3 months ago (2013-09-04 18:58:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/18710003/6001
7 years, 3 months ago (2013-09-04 18:59:32 UTC) #9
commit-bot: I haz the power
7 years, 3 months ago (2013-09-04 22:06:50 UTC) #10
Message was sent while issue was closed.
Change committed as 221278

Powered by Google App Engine
This is Rietveld 408576698